Last modified: 2014-07-23 20:46:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 41259 - Banner content code reuse is lower than it should be
Banner content code reuse is lower than it should be
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2012-10-21 16:01 UTC by Adam Wight
Modified: 2014-07-23 20:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adam Wight 2012-10-21 16:01:35 UTC
This is a bit unfair to file as a bug... but the way CN is used, large blocks of style and other elements are copied between banners.  For many reasons, all this stuff should be saved in a template and only the things which are actually changed should be in each banner text.

Looking through meta CN, I think I've identified an obstacle, and addressed with commit https://gerrit.wikimedia.org/r/28913  -- I found that the common elements never (?) included "message fields", possibly because of a quirk in the translation interface, possibly due to misunderstanding.

The message fields serve as named template parameters, basically.  We should be able to get a lot more use out of this mechanism before resorting to copy n paste.
Comment 1 Adam Wight 2014-07-09 17:15:21 UTC
We've deployed another feature which should help with the code reuse issue:
https://www.mediawiki.org/wiki/Extension:CentralNotice/Banner_mixins

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links