Last modified: 2013-12-04 01:23:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43230, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41230 - Unclosed comment get closed in round-trip
Unclosed comment get closed in round-trip
Status: RESOLVED WONTFIX
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low minor
: ---
Assigned To: Gabriel Wicke
:
Depends on: 41948
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-19 21:22 UTC by Liangent
Modified: 2013-12-04 01:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-10-19 21:22:04 UTC
Feed <!-- to it.
Comment 1 Gabriel Wicke 2012-11-20 04:53:35 UTC
We recently added support for round-tripping of autoclosed tags (just <b> for example), but this relies on internal round-trip data on the element. Comments do not support rt data, so we'd have to wrap the comment in special elements (a span for example), which would be quite ugly.

We are working on selective serialization (only serialize modified parts of the document) to avoid dirty diffs from this kind of issue. This should also prevent auto-closed comments from showing up in diffs unless the last paragraph is edited.
Comment 2 Gabriel Wicke 2013-12-04 01:23:05 UTC
I actually doubt that there is a good use case for supporting this. Afaik the main case where this can happen in practice is when an unclosed comment is at the end of the input. In that case closing the comment introduces a small diff, but is otherwise harmless.

Closing this as wontfix, please reopen if you see a good reason for working on this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links