Last modified: 2012-11-21 22:08:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43227, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41227 - HTML element-like stuff are expanded then broken
HTML element-like stuff are expanded then broken
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 39567
  Show dependency treegraph
 
Reported: 2012-10-19 21:11 UTC by Liangent
Modified: 2012-11-21 22:08 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-10-19 21:11:41 UTC
Try round tripping the following text:

<x y>

<x.y>

<x-y>
Comment 1 Gabriel Wicke 2012-11-20 21:03:02 UTC
I think I fixed this recently (if you ignore the syntactic diff on the attribute):

echo -e '<x y>\n\n<x.y>\n\n<x-y>' | nodejs parse --wt2wt
<x y=''>

<x.y>

<x-y>
Comment 2 Liangent 2012-11-21 07:28:40 UTC
I don't accept this resolution. "HTML element-like stuff" means they're not HTML by author's original idea. For example:

Here are three inequalities:

1>2

x<y

a>b
Comment 3 Gabriel Wicke 2012-11-21 21:38:26 UTC
These examples are now fixed with https://gerrit.wikimedia.org/r/#/c/34569/, and I added a parser test case in https://gerrit.wikimedia.org/r/#/c/34592/.

There is still a minor issue in the HTML output for 

x<y

a>b

Parsoid wraps this in a single paragraph, while the PHP parser produces two separate ones. The corresponding test fails in wt2html mode in Parsoid, so should be fixed at some point. Round-tripping works fine though.

The round-trip breakage in this area should mostly be fixed now, so closing this bug. The render difference can be addressed separately, but is of lower priority right now.
Comment 4 Liangent 2012-11-21 22:03:25 UTC
(In reply to comment #3)
> The render difference can be addressed separately, but is of lower
> priority right now.

Does this need a separate bug?
Comment 5 Gabriel Wicke 2012-11-21 22:08:11 UTC
Not necessarily, as the failing parser test should point that out to us. Can create one though, referencing the 'Tag-like HTML structures are passed through as text' test.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links