Last modified: 2013-08-22 14:54:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43178, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 41178 - Call to a member function isEmpty() on a non-object in EditPage.php


Summary:	Call to a member function isEmpty() on a non-object in EditPage.php

Status:	VERIFIED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	ContentHandler (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-10-18 15:44 UTC by Sam Reed (reedy)
Modified:	2013-08-22 14:54 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-10-18 15:44:33 UTC

[18-Oct-2012 15:40:35] Fatal error: Call to a member function isEmpty() on a non-object at /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php on line 474
Server: mw53
Method: GET
URL: http://www.mediawiki.org/w/index.php?title=Manual:$wgSMTP&action=edit&section=1?printable=yes
Backtrace:
#0 /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php(474): EditPage::displayPermissionsError()
#1 /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php(370): EditPage->displayPermissionsError(Array)
#2 /usr/local/apache/common-local/php-1.21wmf2/includes/actions/EditAction.php(51): EditPage->edit()
#3 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(428): EditAction->show()
#4 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(305): MediaWiki->performAction(Object(Article))
#5 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(554): MediaWiki->performRequest()
#6 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(447): MediaWiki->main()
#7 /usr/local/apache/common-local/php-1.21wmf2/index.php(59): MediaWiki->run()
#8 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#9 {main}

Comment 1 Daniel Kinzler 2012-10-18 17:25:08 UTC

Fix posted as I7d629753

Comment 2 Sam Reed (reedy) 2012-10-18 21:23:39 UTC

Merged and picked

Comment 3 Sam Reed (reedy) 2012-10-18 23:37:18 UTC

This one isn't completely fixed, just seen the error again on the cluster


		$content = $this->getContentObject();

		# Use the normal message if there's nothing to display
		if ( $this->firsttime && ( $content === false || $content->isEmpty() ) ) {

But we've specified there is no parameter to getContentObject(), so it defaults to null

	protected function getContentObject( $def_content = null ) {


meaning $content can still be null...


[18-Oct-2012 23:21:29] Fatal error: Call to a member function isEmpty() on a non-object at /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php on line 474
Server: mw35
Method: GET
URL: http://en.wiktionary.org/w/index.php?title=User:Sano&action=edit&section=3+Result:+chosen+nickname+%22safKarmajom%22;+nofollow+is+found;+success+-+posted+to+first+encountered+partition+%22/w/index.php?$
Backtrace:
#0 /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php(474): EditPage::displayPermissionsError()
#1 /usr/local/apache/common-local/php-1.21wmf2/includes/EditPage.php(370): EditPage->displayPermissionsError(Array)
#2 /usr/local/apache/common-local/php-1.21wmf2/includes/actions/EditAction.php(51): EditPage->edit()
#3 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(428): EditAction->show()
#4 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(305): MediaWiki->performAction(Object(Article))
#5 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(554): MediaWiki->performRequest()
#6 /usr/local/apache/common-local/php-1.21wmf2/includes/Wiki.php(447): MediaWiki->main()
#7 /usr/local/apache/common-local/php-1.21wmf2/index.php(59): MediaWiki->run()
#8 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#9 {main}

Comment 4 Daniel Kinzler 2012-10-19 10:26:17 UTC

Follow-up fix in Id9e307fc

Comment 5 denny vrandecic 2013-08-22 14:54:50 UTC

Closed older resolved bugs as verified.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links