Last modified: 2013-01-11 15:04:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43133, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41133 - all.dblist in beta-labs is a live hack
all.dblist in beta-labs is a live hack
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks: 41132
  Show dependency treegraph
 
Reported: 2012-10-17 21:10 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-01-11 15:04 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-10-17 21:10:40 UTC
On beta, the /home/wikipedia/common/all.dblist is a live hack. It holds the list of database configured on the cluster which, on beta, is different from the one on production.

The beta databases should be listed in a new file named beta.dblist or wmflabs.dblist and all our tools must be adapted to detect they are on beta and load the new file.

Currently, when someone does a git pull and erase the all.dblist, the first database is listed as aawikibooks which does not exist on beta. That causes at least the job runner to die since it can not find the database and throw an exception.
Comment 1 Antoine "hashar" Musso (WMF) 2012-10-19 15:00:07 UTC
https://gerrit.wikimedia.org/r/#/c/28642/ by Sam Reed

beta now uses all-wmflabs.dblist
Comment 2 Antoine "hashar" Musso (WMF) 2012-11-02 14:53:43 UTC
Some scripts in extensions/WikimediaMaintenance still refers to all.dblist explicitly. Among others:

 addWiki.php
 dumpInterwiki.php
 rebuildInterwiki.php
 storage/make-all-blobs
Comment 3 Brad Jorsch 2012-11-02 15:11:50 UTC
I have a vague plan to fix this as a general case, by adjusting everything I can find that looks at *.dblist to first load the realm from /etc/wikimedia-realm (if that exists) and check if *-$realm.dblist exists as an override. Then we can actually commit all the beta-specific versions of these files into git where they should be.

It looks like I'll also wind up doing the same for wikiversions.dat, and hopefully cleaning up some of the rest of the untracked changes in the beta config.
Comment 4 Brad Jorsch 2012-11-07 00:25:29 UTC
Ok, I wound up having to touch operations/mediawiki-config, operations/mediawiki-multiversion, and mediawiki/extensions/WikimediaMaintenance to make this change. And it all needs thorough review.

Gerrit change #32167 has the changes to operations/mediawiki-config
Gerrit change #32168 has the changes to operations/mediawiki-multiversion
Gerrit change #32169 has the changes to mediawiki/extensions/WikimediaMaintenance
Comment 5 Antoine "hashar" Musso (WMF) 2013-01-07 16:02:45 UTC
I think that issue has been fixed when we implemented the multiple datacenter features in mediawiki-config. There is an all-labs.dblist file now since https://gerrit.wikimedia.org/r/#/c/39059/ and IIRC it should be loaded properly when using getRealmSpecificFilename( '/path/to/all.dblist').

Will have to double check all our script properly use that list of databases.
Comment 6 Antoine "hashar" Musso (WMF) 2013-01-11 15:04:14 UTC
We now vary based on the realm. The all.dblist is replaced by all-labs.dblist whenever we run on labs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links