Last modified: 2014-01-03 15:56:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43036, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 41036 - CSS classes mw-content-ltr/mw-content-rtl is missing


Summary:	CSS classes mw-content-ltr/mw-content-rtl is missing

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ExpandTemplates (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://www.mediawiki.org/w/index.php...
Whiteboard:
Keywords:	i18n, patch, patch-need-review

Depends on:
Blocks:	28708
	Show dependency tree / graph

Reported:	2012-10-15 12:18 UTC by Fomafix
Modified:	2014-01-03 15:56 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for ExpandTemplates_body.php (707 bytes, patch) 2012-10-18 17:30 UTC, Fomafix	Details
Add an attachment (proposed patch, testcase, etc.)

Description Fomafix 2012-10-15 12:18:19 UTC

https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?view=markup uses a lot of CSS definitions based on the CSS classes mw-content-ltr or mw-content-rtl. On the preview of [[Special:ExpandTemplates]] the CSS classes mw-content-ltr/mw-content-rtl doesn't exist. So the definitions doesn't work.

Expected result:
The preview should be in a <div class="mw-content-DIR" lang="LANG" dir="DIR"> container based on the direction DIR and the language LANG of the page content language of the context title.

Test case:
  <div class="magnify">float right</div>
should aligned right on a ltr wiki and should left aligned on a rtl wiki.

Comment 1 Andre Klapper 2012-10-15 13:28:37 UTC

(In reply to comment #0)
> https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?view=markup

Just for the records, that's https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=skins/common/shared.css;hb=HEAD nowadays.

Comment 2 Amir E. Aharoni 2012-10-16 06:39:18 UTC

I'm not sure that I understand the example. "float right" here is just text. Did you mean to write it as CSS?

The ExpandTemplates page works correctly for me in an RTL wiki. The mw-content-rtl class is applied to the whole page.

What is the actual problem?

Comment 3 Fomafix 2012-10-16 08:26:16 UTC

skins/common/shared.css contains:

/* @noflip */
.mw-content-ltr .magnify {
        float: right;
}
/* @noflip */
.mw-content-rtl .magnify {
        float: left;
}

class="magnify" should either be float:left or float:right. The text "float right" was just a dummy.

Better test case:
 <div class="magnify">magnify</div>Text

should look like
 <div style="float: right;">magnify</div>Text
on LTR page content language

and

should look like
 <div style="float: left;">magnify</div>Text
on RTL page content language.

Actual result:
 <div>magnify</div>Text
without float.

Comment 4 Amir E. Aharoni 2012-10-16 09:06:00 UTC

Oh, I get it now. Thanks for the clarification.

Comment 5 Fomafix 2012-10-18 17:30:10 UTC

Created attachment 11205 [details]
Patch for ExpandTemplates_body.php

Patch for ExpandTemplates_body.php added

Comment 6 Andre Klapper 2013-02-11 14:59:03 UTC

ping - patch available here, somebody need to bring it into Gerrit.

Comment 7 Brion Vibber 2013-09-27 16:06:21 UTC

Equivalent patch seems to have landed in commit dc0ffb28482e01bcef46a139fe262827c84de9aa, 2013-02-03.

Resolving fixed.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links