Last modified: 2012-11-30 00:41:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43018, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41018 - fixDeprecatedAttributes incorrectly converts the type attribute of lists and list items
fixDeprecatedAttributes incorrectly converts the type attribute of lists and ...
Status: RESOLVED DUPLICATE of bug 40632
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.21.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-14 07:02 UTC by Kevin Israel (PleaseStand)
Modified: 2012-11-30 00:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kevin Israel (PleaseStand) 2012-10-14 07:02:32 UTC
includes/Sanitizer.php includes the following line in the function fixDeprecatedAttributes(), introduced in r94465:

'type' => array( 'list-style-type', array( 'li', 'ol', 'ul' ) ),

There are two problems here:

1. In HTML5, the type attribute is NOT deprecated for ol elements.

2. This line fails to make the following substitutions:

   "1" with "decimal"
   "a" with "lower-alpha"
   "A" with "upper-alpha"
   "i" with "lower-roman"
   "I" with "upper-roman"

Consequently, pages such as Wikipedia:Text of Creative Commons Attribution-ShareAlike 3.0 Unported License on the English Wikipedia do not render correctly when both $wgHtml5 and $wgCleanupPresentationalAttributes are enabled. As of revision 505139539, the subsections of that page are numbered with Arabic numerals, rather than with lowercase letters as they should be.
Comment 1 MZMcBride 2012-10-14 16:44:33 UTC
Dupe of bug 40632?
Comment 2 Kevin Israel (PleaseStand) 2012-11-30 00:41:53 UTC
The problematic code was entirely removed in both master and MediaWiki 1.20.1, so I can close this bug now.

*** This bug has been marked as a duplicate of bug 40632 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links