Last modified: 2013-08-22 14:55:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42653, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40653 - Consider using canonical parser options for Content::getParserOutput()
Consider using canonical parser options for Content::getParserOutput()
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
ContentHandler (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks: 38622
  Show dependency treegraph
 
Reported: 2012-10-01 09:33 UTC by Daniel Kinzler
Modified: 2013-08-22 14:55 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-10-01 09:33:02 UTC
IAlex wrote in a comment to I3b2dad3a:

  From the use cases I see, this is wrong, since constructing a ParserOptions 
  object without any parameter will use $wgUser and $wgLang. This will cause the 
  result to be user-dependant when executing links update (i.e. regression of  
  bug 14404 and maybe others too). I would suggest to use something like:
  
  $wikiPage = WikiPage::factory( $title );
  
  $options = $wikiPage->makeParserOptions( 'canonical' );

This needs some investigation to make sure we do the right thing for every context this function is used in. Note also interactions with the parser cache, especially wrt the parser cache key.
Comment 1 Daniel Kinzler 2012-10-04 11:04:31 UTC
Fixed in I2cbfaab2
Comment 2 denny vrandecic 2013-08-22 14:55:33 UTC
Closed older resolved bugs as verified.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links