Last modified: 2012-09-18 12:54:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42306, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40306 - Align HTML4 -> HTML5 transform broken on tablerows.
Align HTML4 -> HTML5 transform broken on tablerows.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All Linux
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 40323 40324 (view as bug list)
Depends on:
Blocks: html5
  Show dependency treegraph
 
Reported: 2012-09-17 19:16 UTC by Giftpflanze
Modified: 2012-09-18 12:54 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Giftpflanze 2012-09-17 19:16:59 UTC
On https://de.wikipedia.org/w/index.php?title=Wikipedia:Checkuser/Wahl/September_2012/Zwischenst%C3%A4nde&action=submit, when clicking on preview, the table is totally crazy. It is reported that it is the same on normal view. May be HTML5 related?
Comment 1 Derk-Jan Hartman 2012-09-17 19:44:24 UTC
Caused by the align on table rows being incorrectly transformed to float, whereas align on table rows determines content alignment.

This is a bug in our HTML4->HTML5 normalization. Should be easy to fix.
Comment 2 Jesús Martínez Novo (Ciencia Al Poder) 2012-09-17 19:58:21 UTC
(edit conflict)

When a table row has align=right it's now converted to <tr style="float:
right;">!! which causes this weird display.

This is caused by Gerrit change #13479 -> Anything that are not cells (td, th)
and has align is converted to float, except if it's align=center. It should
have included table rows as well.

This problem surfaces now because of bug 27478

It happens when preview because the switch to HTML5 has been done recently.
When the page cache is refreshed, it will look weird also on page view (unless
HTMLTidy is sanitizing it)

[Importance changed to high]
Comment 3 Antoine "hashar" Musso (WMF) 2012-09-17 20:18:11 UTC
Working on it with https://gerrit.wikimedia.org/r/24076
Comment 4 Antoine "hashar" Musso (WMF) 2012-09-17 20:39:55 UTC
The Gerrit change #24076 makes it so <tr align="X"> is converted to use the style="text-align: X;" for TR elements.
Comment 5 Derk-Jan Hartman 2012-09-18 00:10:09 UTC
New patchset submitted (though for some reason it seems to have picked the cherry picked version on the wmf12 branch.
Comment 6 Derk-Jan Hartman 2012-09-18 11:25:42 UTC
*** Bug 40323 has been marked as a duplicate of this bug. ***
Comment 7 Derk-Jan Hartman 2012-09-18 11:26:32 UTC
*** Bug 40324 has been marked as a duplicate of this bug. ***
Comment 8 Derk-Jan Hartman 2012-09-18 11:29:24 UTC
https://gerrit.wikimedia.org/r/#/c/24080/
Comment 9 Antoine "hashar" Musso (WMF) 2012-09-18 12:54:41 UTC
Tested change on https://test.wikipedia.org/wiki/Bug40306

Deployed it live at Tue, 18 Sep 2012 12:53:40 +0000


Pages in squid cache will need to be purged manually. That will self fix whenever an edit is made.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links