Last modified: 2014-03-04 13:31:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42238, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 40238 - apply correct lang and dir attributes to language names in "List of pages linked to this item"


Summary:	apply correct lang and dir attributes to language names in "List of pages lin...

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	storypoints: 2
Keywords:	need-volunteer

Depends on:	41103
Blocks:	rtl-wikidata
	Show dependency tree / graph

Reported:	2012-09-13 15:29 UTC by Amir E. Aharoni
Modified:	2014-03-04 13:31 UTC (History)
CC List:	10 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2012-09-13 15:29:34 UTC

Language names appear as autonyms, so correct lang and dir attribute must be applied to every table cell with a language name.

Comment 1 Amir E. Aharoni 2012-10-13 16:00:25 UTC

Partial fix in https://gerrit.wikimedia.org/r/#/c/27873/ .

Comment 2 Daniel Kinzler 2012-10-17 10:04:59 UTC

Reverting the above change (revert is I19fe52d0) because the proposed solution causes us to run out of memory.

Constructing a Language object for each language loads all the messages for every language and causes an out of memory error on pages with a non-trivial number of sitelinks. Each language seems to require about 500KB of memory.

We need a lightweight way to get the names and directionality of all languages, without loading all the messages. Lazy initialization of the Language object could help. Of there could be a LanguageInfo interface for stuff like name and directionality.

Comment 3 Andy Mabbett 2012-11-09 00:01:30 UTC

There should also be an hreflang attribute on links to other-langugae wikis.

Comment 4 Tpt 2012-11-09 09:34:50 UTC

Very partial fix in https://gerrit.wikimedia.org/r/#/c/32501/

Comment 5 Lydia Pintscher 2012-11-10 12:01:29 UTC

fix was merged
Thanks Tpt!

Comment 6 db [inactive,noenotif] 2012-11-18 12:59:36 UTC

(In reply to comment #4)
> Very partial fix in https://gerrit.wikimedia.org/r/#/c/32501/

Status Merged

Comment 7 Tpt 2012-11-18 20:44:48 UTC

The fix merged is only partial so the bug isn't fixed.

Comment 8 Andre Klapper 2013-07-23 09:13:06 UTC

Removing patch-in-gerrit keyword as the partial patch was merged.

Comment 9 Lydia Pintscher 2014-02-21 11:23:34 UTC

This seems fixed now. Please reopen with specific description of what is still broken if not.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links