Last modified: 2013-05-17 17:23:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42140, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40140 - VisualEditor: High-res icons don't display if small screen is resized to large
VisualEditor: High-res icons don't display if small screen is resized to large
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-10 20:12 UTC by Brion Vibber
Modified: 2013-05-17 17:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-09-10 20:12:42 UTC
Broken out from bug 37849: window.devicePixelRatio is checked when loading stuff, and then either a stylesheet for 1.0x PNGs or one using scalable SVGs gets loaded depending on the ratio.

This leads to being stuck with the 1.0x PNGs if you started editing on a low-resolution screen, then moved the window (or detached an external monitor) and moved it to a high-resolution screen.

Per bug 37849 comment 9 there are probably two ways to fix this:

1) Detect resolution changes (window.onresize?) and switch the stylesheet based on the updated window.devicePixelRatio

or

2) Always use SVG icon set if SVG is supported in the browser.

Note that Firefox doesn't yet support window.devicePixelRatio, but it's about to come in in nightlies, before actual HiDPI support for Mac OS X :) -- https://bugzilla.mozilla.org/show_bug.cgi?id=564815

IE 10 doesn't support window.devicePixelRatio at all, which is a bit annoying although it does support SVG and high-resolution screens eg on Windows 8. We can leave that as a corner case for the moment, though use of SVG at all resolutions would conveniently work around it.
Comment 1 Krinkle 2012-09-11 17:53:14 UTC
Keywords spam: High-density HiDPI Retina toolbar icons don't display if window opened on low-res screen, then moved to high-res.
Comment 2 James Forrester 2012-10-01 18:25:24 UTC
Mark as enhancement; this is nothing like a priority ahead of December. :-)
Comment 3 James Forrester 2013-05-17 17:23:58 UTC
This is now invalid, as we actually provide the SVGs by default to every browser that doesn't fail on them (yay).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links