Last modified: 2013-07-27 05:42:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42034, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40034 - VisualEditor: Pressing enter in a textarea should not submit the form (saveDialog-editSummary)
VisualEditor: Pressing enter in a textarea should not submit the form (saveDi...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2012-09-17
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-06 00:45 UTC by Krinkle
Modified: 2013-07-27 05:42 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-09-06 00:45:20 UTC
Submitting the form on Enter in the current UI goes against all expectations.

It is hardcoded in the javascript to override the default behavior (browsers are actually quite sane in this case and know not to auto-submit from a textarea because that's bad).

Either make it not a text area or make it not submit on Enter.
Comment 1 James Forrester 2012-09-06 16:26:24 UTC
Actually, this is exactly the current behaviour of the edit summary box; see bug 38042 and bug 38735 (the last one submitted by you :-)).
Comment 2 Krinkle 2012-09-11 14:44:35 UTC
(In reply to comment #1)
> Actually, this is exactly the current behaviour of the edit summary box; see
> bug 38042 and bug 38735 (the last one submitted by you :-)).

Interesting. Was it a textarea back then?
Comment 3 Rob Moen 2012-09-11 16:34:31 UTC
No, previously it was a text input.
Patched in https://gerrit.wikimedia.org/r/23422
Comment 4 Liangent 2012-09-11 16:40:43 UTC
Do we really need a textarea?

Newlines are not shown in page history.
Comment 5 Krinkle 2012-09-11 17:15:52 UTC
(In reply to comment #4)
> Do we really need a textarea?
> 
> Newlines are not shown in page history.

Maybe, maybe not. Either way, that's a separate request.

Besides, when it is a text input Enter will submit the form automatically (browser behavior) which is good. So this change had to be made either way. If you want, file a separate ticket to turn it into a single-line text input.

Note that textarea provides another thing besides multi-line: wrapping.

It is much nicer to type a long line in a textarea then a flat input because there is no need to use the horrible scrubbing behavior that browsers have (select-dragging or keyboard arrows only). I've encountered numerous times during usability studies that a user thought the begin of the input was lost when it was no longer visible (there is no visual indication that it is still there, e.g. scroll or whatever). Or that the end was lost (when they focus another element, other elements scroll back to the begin).
Comment 6 MZMcBride 2013-07-27 05:42:06 UTC
(In reply to comment #5)
> Maybe, maybe not. Either way, that's a separate request.
> [...]
> If you want, file a separate ticket to turn it into a single-line text input.

bug 52133

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links