Last modified: 2013-03-22 12:21:34 UTC
For example, if only inline comments were posted, or if someone +1's without any comments.
(In reply to comment #0) > For example, if only inline comments were posted, or if someone +1's without > any comments. The latter was done on purpose, to reduce the amount of spam (nobody on IRC really cares if a commit was +1'd but didn't bother to comment). The former happened as a consequence of doing the latter.
So am I supposed to write "See inline." every time I write inline comments if I want IRC notification to work properly? Because this sort of doubles the functionality already offered by gerrit (the (N inline comments) notices) and, frankly, is stupid.
(In reply to comment #2) > So am I supposed to write "See inline." every time I write inline comments if I > want IRC notification to work properly? > Unless someone improves the hooks further to distinguish between the two cases, yes. This has been the case for quite some time now. Having to include a cover message is mildly annoying, but I considered it an acceptable tradeoff at the time to silence the gerrit spam from +1s with no comment, and the even more annoying +2/Submit spam when someone approves & submits in one step with no comment (we only need one notification of the submit, not an empty +2 as well). The hook stuff is not gerrit code, it's something we wrote and maintain in the puppet repo. The files are all in files/gerrit/hooks/*. I welcome improvements to it and would be more than happy to review them, but I probably won't personally revisit the issue for awhile.
This was fixed indirectly as a result of the comment format changing.
