Last modified: 2012-09-02 16:32:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41895, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39895 - Adm1 doesn't contain ISO codes for Serbia


Summary:	Adm1 doesn't contain ISO codes for Serbia

Status:	RESOLVED FIXED

Product:	Wiki Loves Monuments
Classification:	Unclassified
Component:	Sources (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://wlm.wikimedia.org/api/api.php?...
Whiteboard:
Keywords:

Depends on:
Blocks:	39882
	Show dependency tree / graph

Reported:	2012-09-01 13:25 UTC by Maarten Dammers
Modified:	2012-09-02 16:32 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Maarten Dammers 2012-09-01 13:25:42 UTC

http://wlm.wikimedia.org/api/api.php?action=adminlevels&format=json&admtree=rs contains names that get truncated, should be like https://en.wikipedia.org/wiki/ISO_3166-2:RS

Comment 1 Maarten Dammers 2012-09-01 17:17:53 UTC

Elke, can you have a look at this?

Comment 2 elya 2012-09-01 19:25:59 UTC

We have  adm1 information, but it's not ISO. What's the problem, afaik ISO was a nice-to-have-feature here...

Comment 3 Maarten Dammers 2012-09-01 21:10:38 UTC

adm0 and adm1 always have to be an iso code.

Comment 4 elya 2012-09-02 08:20:27 UTC

sent a diff with iso_okrug

Comment 5 elya 2012-09-02 09:05:21 UTC

3 lists updated with iso values.

Comment 6 Maarten Dammers 2012-09-02 10:13:12 UTC

Getting a warning:
"""

Getting 34 pages from wikipedia:sr...
Found unknown field: ISO on page Ð¡Ð¿Ð¸ÑÐ°Ðº_Ð°ÑÑ
ÐµÐ¾Ð»Ð¾ÑÐºÐ¸Ñ
_Ð½Ð°Ð»Ð°Ð·Ð¸ÑÑÐ°_Ñ_Ð¡ÑÐ±Ð¸ÑÐ¸
Field: ISO
Value: RS-04 """

The iso field is case sensitive. I'm picking up some iso codes, but not everything is filled yet:

mysql> SELECT `iso_okrug`, COUNT(`iso_okrug`) FROM `monuments_rs_(sr)` GROUP BY `iso_okrug`;
+-----------+--------------------+
| iso_okrug | COUNT(`iso_okrug`) |
+-----------+--------------------+
|           |               2113 |
| RS-00     |                 37 |
| RS-01     |                  8 |
| RS-02     |                  3 |
| RS-03     |                  3 |
| RS-04     |                  6 |
| RS-05     |                  6 |
| RS-06     |                 31 |
| RS-07     |                 38 |
| RS-08     |                 13 |
| RS-09     |                 10 |
| RS-10     |                  1 |
| RS-11     |                  7 |
| RS-12     |                 10 |
| RS-13     |                  6 |
| RS-14     |                 31 |
| RS-15     |                 10 |
| RS-16     |                 19 |
| RS-17     |                  6 |
| RS-18     |                 15 |
| RS-19     |                 10 |
| RS-20     |                 13 |
| RS-21     |                  2 |
| RS-22     |                  2 |
| RS-23     |                  6 |
| RS-24     |                  2 |
| RS-KM     |                  2 |
+-----------+--------------------+
27 rows in set (0.02 sec)

Comment 7 elya 2012-09-02 13:14:15 UTC

one row was with "ISO" instead of "iso", fixed this. Asked the local team to check it.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links