Last modified: 2013-06-11 23:26:07 UTC
The current wikitext escape algorithm adds excessive nowiki tags around quote marks. While these are semantically correct and useful, for existing code, it introduces dirty diffs with the source wikitext. This is not a problem if unmodified DOM subtrees are serialized using original wikitext source. But, we dont this right now. Till such time, the code needs fixing to use heuristics to eliminate nowikis where the parser can figure out the right parse without nowikis.
Since quote heuristics are relatively complex, I guess the simplest and most reliable solution to figure out if escaping for quotes in a line is really needed would be to round-trip test the output for that line.
*** Bug 47442 has been marked as a duplicate of this bug. ***
Note also that through continuous edits more cruft might be added around the same source text, and at some point ugly visual changes do occur. See the bold text at http://en.wikipedia.org/w/index.php?title=Yolanda_Ordaz_de_la_Cruz&oldid=551330208#Impact . It appeard through several edits, each one adding a bit. See the diff of the fix: http://en.wikipedia.org/w/index.php?title=Yolanda_Ordaz_de_la_Cruz&diff=551330391&oldid=551330208
(In reply to comment #3) > Note also that through continuous edits more cruft might be added around the > same source text, and at some point ugly visual changes do occur. This is VisualEditor bug 47434, which is fixed in VE master, but not yet deployed.
We are using selective serialization by default, so this is no longer a major issue in practice.
