Last modified: 2012-08-19 02:14:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41256, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39256 - UploadWizard fails with "unknown-warning" when file of the name was previously deleted
UploadWizard fails with "unknown-warning" when file of the name was previousl...
Status: RESOLVED DUPLICATE of bug 39303
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-10 23:55 UTC by Brion Vibber
Modified: 2012-08-19 02:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-08-10 23:55:05 UTC
iOS 6 adds support for <input type="file">, which should make it possible to perform file uploads on iPhones, iPads, and iPod Touches.


Split out from bug 32328 comment 5:

Testing on the current beta, things partially work -- after selecting an image
I end up with a thumbnail and all -- then I get "Unknown error:
unknown-warning" during the upload stage.

Selecting a second image similarly partially works/partially fails, then pops
up a dialog warning that "You are already uploading the file "image.jpg"."
(apparently every file gets named as image.jpg during uploading...)
Comment 1 Brion Vibber 2012-08-11 00:05:24 UTC
The unknown warning may be simply the 'was-deleted' based on the filename:

{
  "upload": {
    "result":"Success",
    "filekey":"10rzmlb07tj8.ckjgaf.123.jpg",
    "sessionkey":"10rzmlb07tj8.ckjgaf.123.jpg",
    "warnings": {
      "was-deleted":"Image.jpg"
    },
    "imageinfo":{.....}
...


This should definitely not be preventing the upload from going on to the next step, especially since we're going to change the filename! :(

The other popup warning appears to be internal to UploadWizard, and should perhaps special-case that multiple "image.jpg"s are expected on iOS.
Comment 2 Brion Vibber 2012-08-11 00:09:25 UTC
Confirmed uploading to http://test.wikipedia.org/ that without the failed warning, upload works as expected in iPad simulator w/ iOS 6.0 beta4.

Warning happens consistently on https://commons.wikimedia.org/ preventing any uploads there.
Comment 3 Brion Vibber 2012-08-11 00:16:40 UTC
Adding dep on bug 37039
Comment 4 Brion Vibber 2012-08-11 00:18:00 UTC
Hm, actually that looks distinct. Sigh. :D
Comment 5 Mark Holmquist 2012-08-16 16:34:40 UTC
Hi!

Recently, a patch to MediaWiki core [0] changed the behavior of API warnings. We now get those at the first step, even if we don't handle them necessarily.

Could you try to reproduce this bug, and let us know if it still occurs? If so, the solution would likely be very different from before this patch.

Also with this bug, I think there might be related functionality in other patches [1][2], so if you get a moment, review and/or lobbying for review would be helpful :)

[0] https://gerrit.wikimedia.org/r/#/c/9261/
[1] https://gerrit.wikimedia.org/r/#/c/8728/
[2] https://gerrit.wikimedia.org/r/#/c/9259/

Thanks!
Comment 6 Brion Vibber 2012-08-16 21:07:53 UTC
With current core & UploadWizard running locally, if I:

* first upload some image
* then delete it

to establish the situation then test:

* upload the same image again

I see a warning that an image with the same *content* has been previously uploaded, and the opportunity to continue.

If I:

* upload a different image

Then I get the same "unknown-warning" warning as I do on Commons. Unfortunately Safari is crashing on me when I try to connect to the simulator with the JavaScript debugger so I'm not sure exactly what response is coming back.
Comment 7 Erik Moeller 2012-08-19 02:10:59 UTC
https://gerrit.wikimedia.org/r/#/c/9261/ definitely appears to have caused a bunch of regressions that need to be addressed in Upload Wizard itself.
Comment 8 Erik Moeller 2012-08-19 02:14:38 UTC

*** This bug has been marked as a duplicate of bug 39303 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links