Last modified: 2012-10-30 05:30:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41195, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39195 - UploadBase: Fatal error: Call to a member function getName() on a non-object
UploadBase: Fatal error: Call to a member function getName() on a non-object
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: Highest critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-09 13:41 UTC by Sam Reed (reedy)
Modified: 2012-10-30 05:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-08-09 13:41:38 UTC 
PHP Fatal error:  Call to a member function getName() on a non-object in /usr/local/apache/common-local/php-1.20wmf9/includes/upload/UploadBase.php on line 553
Comment 1 Sam Reed (reedy) 2012-08-09 15:10:24 UTC 
		$localFile = $this->getLocalFile();
		$filename = $localFile->getName();

getLocalFile() can (and is, repeatedly on WMF wikis running wmf9) and does return null
Comment 2 Sam Reed (reedy) 2012-10-09 21:47:17 UTC 
PHP Fatal error:  Call to a member function getName() on a non-object in /usr/local/apache/common-local/php-1.21wmf1/includes/upload/UploadBase.php on line 558


At this moment there are 187 in the last 1000 lines of the apache logs
Comment 3 Aaron Schulz 2012-10-10 22:31:57 UTC 
Looks like something is not checking validateName()...
Comment 4 Aaron Schulz 2012-10-10 23:15:46 UTC 
https://gerrit.wikimedia.org/r/#/c/27483/
Comment 5 Sumana Harihareswara 2012-10-12 14:57:06 UTC 
Patchset merged; closing as fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links