Last modified: 2014-01-04 11:22:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41139, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39139 - Translate links should be protocol-relative; avoid red links
Translate links should be protocol-relative; avoid red links
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TranslationNotifications (Other open bugs)
unspecified
All All
: Normal normal with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
https://no.wikipedia.org/wiki/Brukerd...
:
: 45185 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 11:58 UTC by Jon Harald Søby
Modified: 2014-01-04 11:22 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Harald Søby 2012-08-08 11:58:39 UTC
The link to the translate page on my user talk page is not protocol-relative, thus I made several edits without being logged in before realizing that.

Also, the link to the translatable page does not use the [[m:]] prefix, so it is a red link to the local wiki.

Both can be seen on my user talk on nowiki: https://no.wikipedia.org/wiki/Brukerdiskusjon:Jon_Harald_S%C3%B8by#Oversettelsesvarsel

(I would love to (try and) fix this myself, but can't get Gerrit to work. Can you point me to a good guide?)
Comment 1 Jon Harald Søby 2013-01-29 15:16:58 UTC
(bump)
The part about the [[m:]] prefix has been solved, but the protocol-relativity is still an issue. It should be easy to fix, just change instances of http:// to // (but of course you know that).

And again, I can't be bothered to try Gerrit.
Comment 2 Andre Klapper 2013-02-26 20:53:06 UTC
*** Bug 45185 has been marked as a duplicate of this bug. ***
Comment 3 Tilman Bayer 2013-03-01 06:05:39 UTC
I agree that protocol-relative links should be used in the talk pages notifications. A translator from China pointed this out as a security issue to me (https://meta.wikimedia.org/w/index.php?diff=4822644&oldid=4502873 ).

Obviously, protocol-relative links usually won't work in the email notifications; it would be nice to use HTTPS for those by default.
Comment 4 Gerrit Notification Bot 2013-09-18 19:19:12 UTC
Change 84849 had a related patch set uploaded by Siebrand:
Allow always using https links in emails

https://gerrit.wikimedia.org/r/84849
Comment 5 Siebrand Mazeland 2013-10-07 10:50:10 UTC
Patch has been waiting for review for close to 3 weeks.
Comment 6 Siebrand Mazeland 2013-10-29 14:57:49 UTC
Patch has been waiting for merge for 6 weeks now. It was +1-ed 2 weeks ago by Legoktm.
Comment 7 Gerrit Notification Bot 2013-11-26 10:01:46 UTC
Change 84849 abandoned by Siebrand:
Allow always using HTTPS links in emails

Reason:
No reviewers in

https://gerrit.wikimedia.org/r/84849
Comment 8 Siebrand Mazeland 2013-11-26 10:03:16 UTC
I abandoned the patch set. I've tried everything to get the code reviewed, but wasn't able to in two months. Needed to clean up my gerrit dashboard.
Comment 9 Huji 2013-11-28 17:02:07 UTC
I understand that you need to cleanup your dashboard, yet I don't see a reason why that change needs to be abandoned. Can you assign it to me? I don't mind having it on my dashboard. Would you mind if I checkout that change, create a different branch and store it there, and wait for someone to review?
Comment 10 Siebrand Mazeland 2013-11-28 17:08:35 UTC
Huji: No problem.
Comment 11 Gerrit Notification Bot 2013-12-15 18:41:09 UTC
Change 84849 restored by Amire80:
Allow always using HTTPS links in emails

Reason:
The code is valid for review, it just waited too long.

https://gerrit.wikimedia.org/r/84849
Comment 12 Gerrit Notification Bot 2014-01-03 18:04:18 UTC
Change 84849 merged by jenkins-bot:
Allow always using HTTPS links in emails

https://gerrit.wikimedia.org/r/84849

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links