Last modified: 2013-05-30 12:40:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40830, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38830 - Review Diff lib extension for deployment
Review Diff lib extension for deployment
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Chris Steipp
:
Depends on:
Blocks: 40000
  Show dependency treegraph
 
Reported: 2012-07-30 08:15 UTC by Daniel Kinzler
Modified: 2013-05-30 12:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-07-30 08:15:29 UTC
Review Diff lib extension for deployment. It can be found on Gerrit in the mediawiki/extensions/Diff project. The Diff extension acts as a library for other extensions and is used by WIkibase on both client and repository sites.
Comment 1 Rob Lanphier (RobLa) 2012-08-09 14:48:36 UTC
Assigning to Tim for now.  We have some ideas of how to split the review work up a little differently, so we may change these around before reassigning.
Comment 2 Jeroen De Dauw 2012-08-09 14:51:38 UTC
Diff is pretty small and should be easy-ish to review. This can already be done now, as I don't expect much change to it. Also, it has over 98% test coverage :)

It currently holds two components that have been split of as commits to core, would be great if these could be reviewed first, so I can make corresponding changes in the Diff extension, and then have that reviewed.

* https://gerrit.wikimedia.org/r/#/c/16833/
* https://gerrit.wikimedia.org/r/#/c/16834/
Comment 3 Rob Lanphier 2012-11-01 01:05:16 UTC
I believe the security+architecture review that Chris did, plus all of the architecture discussions we've had, are sufficient for a deployment.  Please reopen if you feel we need additional review on any of these.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links