Last modified: 2014-09-01 22:15:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40726, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38726 - VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon)
VisualEditor: Links should follow the local CSS rules as if they were rendere...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-05-01
Assigned To: James Forrester
:
Depends on: 37902
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 19:27 UTC by James Forrester
Modified: 2014-09-01 22:15 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2012-07-26 19:27:24 UTC
This sounds to me like it might be hideously complicated, but putting it in here - e.g. a link to [http://foo.com] gets an external link notification icon on its right on the English Wikipedia, and this should show up as appropriate.
Comment 1 John Mark Vandenberg 2013-07-12 23:29:25 UTC
Applying the same CSS may be difficult, but internal vs external links should be rendered differently somehow.
Comment 2 Gerrit Notification Bot 2014-04-30 23:52:03 UTC
Change 130769 had a related patch set uploaded by Jforrester:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769
Comment 3 Gerrit Notification Bot 2014-05-01 00:26:44 UTC
Change 130769 merged by jenkins-bot:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769
Comment 4 Rummana Yasmeen 2014-05-06 20:05:19 UTC
Verified the fix in Betalabs and test2
Comment 5 Rummana Yasmeen 2014-05-13 20:19:19 UTC
Verified the fix in production
Comment 6 Spinningspark 2014-08-11 13:33:30 UTC
I'm not seeing this as entirely fixed.  The redlink issue has been fixed but there are still other colour issues:

* Visited redlinks are not shown in the visited redlink colour, they are shown in the redlink colour.
* External links are not shown in the external links colour, they are shown in the internal links colour.
* Link icons are omitted: external, secure, pdf etc.

The raison d'etre of VE is that it is WYSIWYG while editing.  Not having links in the right colour defeats this and can lead to mistakes.
Comment 7 Roan Kattouw 2014-08-13 01:24:16 UTC
(In reply to Spinningspark from comment #6)
> I'm not seeing this as entirely fixed.  The redlink issue has been fixed but
> there are still other colour issues:
> 
> * Visited redlinks are not shown in the visited redlink colour, they are
> shown in the redlink colour.
> * External links are not shown in the external links colour, they are shown
> in the internal links colour.
> * Link icons are omitted: external, secure, pdf etc.
> 
This caught my attention because external link icons have been working for me for a while. Turns out they work in Vector but not in Monobook. This appears to be a bug in Monobook, it's scoping link icon CSS to the wrong div (#bodyContent instead of #content).
Comment 8 Gerrit Notification Bot 2014-08-13 01:29:16 UTC
Change 153740 had a related patch set uploaded by Catrope:
Scope external link styling rules to #content rather than #bodyContent

https://gerrit.wikimedia.org/r/153740
Comment 9 Gerrit Notification Bot 2014-08-15 22:54:57 UTC
Change 153740 abandoned by Catrope:
Scope external link styling rules to #content rather than #bodyContent

Reason:
Yeah, that looks much better, thanks guys.

https://gerrit.wikimedia.org/r/153740
Comment 10 Gerrit Notification Bot 2014-08-16 14:52:39 UTC
Change 151395 had a related patch set uploaded by Jforrester:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395
Comment 11 Gerrit Notification Bot 2014-09-01 20:30:34 UTC
Change 151395 merged by jenkins-bot:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395
Comment 12 James Forrester 2014-09-01 22:15:53 UTC
Marking this back as FIXED (as it has been fixed in Vector for a while).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links