Last modified: 2012-11-29 16:04:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40542, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38542 - Page title not replaced by item label when viewing old revisions.
Page title not replaced by item label when viewing old revisions.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
http://wikidata-test-repo.wikimedia.d...
:
: 38180 39128 (view as bug list)
Depends on:
Blocks: 38975
  Show dependency treegraph
 
Reported: 2012-07-21 00:45 UTC by merl
Modified: 2012-11-29 16:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2012-07-21 00:45:54 UTC
http://wikidata-test-repo.wikimedia.de/w/index.php?title=Data:Q2075&diff=prev&oldid=238419&uselang=en

->Difference between revisions of "Data:Q2075"

http://wikidata-test-repo.wikimedia.de/w/index.php?title=Data:Q2075&diff=prev&oldid=238420&uselang=en

->Difference between revisions of "Japanese language"

I think the diff heading should be the same on both diffs because an en-label exists since the first version.
Comment 1 Daniel Kinzler 2012-07-21 10:16:52 UTC
no it doesn't. the first revision doesn't have a label: 

http://wikidata-test-repo.wikimedia.de/w/index.php?title=Data:Q2075&oldid=227434&uselang=en

The first revision has a *link* to the en wikipedia. That is not at all the same as an english language label.

We could derive a fallback label from the language links, if we have a reliable mapping from languages to sites... That could/should be done during item creation though, not on the fly - that would be confusing. 

I think it should be up to the code creating the item to generate the default labels though. Don't know what mechanism created this item here.
Comment 2 Daniel Kinzler 2012-07-21 10:27:51 UTC
So... looking at the JSON, the label *is* there from the fist revision.

Apparently, the page title is replaced with the item label only if the current revision is show. For old revision, this doesn't work at all for some reason.

This is a bug, so I'll re-open this ticket. Also changing the description.
Comment 3 jeblad 2012-07-23 09:35:31 UTC
This solves the label issue https://gerrit.wikimedia.org/r/#/c/16257/ but note that there also is an issue with labels and descriptions being editable.
Comment 4 Daniel Kinzler 2012-07-24 09:56:30 UTC
Now it seems to be even more broken: the label is *never* shown, I always see the internal title.
Comment 5 denny vrandecic 2012-10-17 21:30:39 UTC
*** Bug 38180 has been marked as a duplicate of this bug. ***
Comment 6 denny vrandecic 2012-10-17 21:36:30 UTC
*** Bug 39128 has been marked as a duplicate of this bug. ***
Comment 7 db [inactive,noenotif] 2012-11-18 13:39:41 UTC
Gerrit change #31657 (Status Merged) links here, but not linked back. Is this fixed?
Comment 8 denny vrandecic 2012-11-28 13:35:30 UTC
Seems to be fixed with the Gerrit change.
Comment 9 abraham.taherivand 2012-11-29 16:04:25 UTC
Verified in Wikidata demo for sprint 24

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links