Last modified: 2012-10-29 14:46:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40370, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38370 - jquery.tablesorter should not interpret data-sort-value without leading zeros
jquery.tablesorter should not interpret data-sort-value without leading zeros
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/w/index.php...
:
Depends on:
Blocks: 39480
  Show dependency tree / graph
 
Reported: 2012-07-12 22:29 UTC by Niklas Laxström
Modified: 2012-10-29 14:46 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2012-07-12 22:29:27 UTC 
Try to sort the column which says Vertaald. The value will sort incorrectly. This only happens with Dutch as the user language.
Comment 1 Michael M. 2012-07-14 08:23:45 UTC 
The decimal point is recogognized as thousand seperator, and thus removed, causing the wrong sorting.

*** This bug has been marked as a duplicate of bug 34093 ***
Comment 2 Niklas Laxström 2012-07-14 13:03:27 UTC 
Not so fast. There isn't decimal points in that column (or any column even), and it has data-sort-value in it.
Comment 3 Michael M. 2012-07-17 09:03:25 UTC 
The data-sort-value has a decimal point which is treated the same way it would be treated if it were plain data in a table cell, i.e. the point is removed, the result is treated as number.

Value    data-sort-value    sorted as
100%     1.00000                1
8%       0.08730              873
2%       0.02381             2381
...
10%      0.10317            10317
...
99%      0.99206            99206
Comment 4 Niklas Laxström 2012-07-17 10:40:38 UTC 
sort-value should be treated as binary! Besides, I have not been able to reproduce this on other languages which use the same number format.
Comment 5 Krinkle 2012-07-20 01:45:59 UTC 
Renaming bug to be more specific. "Sorts wrong" is not helpful and not realistically fixable as it would have to cover all past and future bugs ever with sorting in jquery.tablesorter.

If there are other cases than the one I described, please create separate bugs.
Comment 6 Nemo 2012-09-06 08:49:13 UTC 
Bug 27721 was similar, adding Robin to cc.
Comment 7 Niklas Laxström 2012-10-29 14:46:35 UTC 
I don't know who did what, but the example url it works now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links