Last modified: 2014-11-19 21:50:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40233, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38233 - Jenkins: Fail on BOM in submitted files
Jenkins: Fail on BOM in submitted files
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-07 18:15 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-11-19 21:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-07-07 18:15:10 UTC 
We let BOM enter our repository which is definitely unwanted. Sam had to recently remove one in mediawiki/core https://gerrit.wikimedia.org/r/14622
Comment 1 Antoine "hashar" Musso (WMF) 2012-10-17 08:09:01 UTC 
This could be added to the linting job. We need a script to actually detect the BOM.
Comment 2 Antoine "hashar" Musso (WMF) 2013-01-30 13:01:47 UTC 
This is properly covered by the PHP_CodeSniffer rule "Generic.Files.ByteOrderMark" which we have in the MediaWiki standard.

Still have to get Jenkins to fail on phpcs checks which are non voter for now.
Comment 3 Krinkle 2014-11-19 21:50:14 UTC 
I don't think we should have a generic job that scans all files everywhere for a BOM. Instead let's defer this to individual linters or coding style checkers.

phpcs has a sniff for it. So that's good.
Let's look into jscs as well.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links