Last modified: 2012-12-31 17:24:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40158, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38158 - jquery.byteLimit sometimes causes an unexpected 0 maxLength being enforced
jquery.byteLimit sometimes causes an unexpected 0 maxLength being enforced
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: High major (vote)
: 1.20.0 release
Assigned To: Krinkle
: code-update-regression
Depends on:
  Show dependency treegraph
Reported: 2012-07-04 08:49 UTC by Siebrand Mazeland
Modified: 2012-12-31 17:24 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Siebrand Mazeland 2012-07-04 08:49:27 UTC
MediaWiki 1.20 / 07b8a42dddab0bb1cbfd0cd933929bbcc2170d54

Cannot edit edit summary field in Firefox13 and Chrome 21.0.1180.15 dev/OSX.

Antoine is bisecting.
Comment 1 Antoine "hashar" Musso (WMF) 2012-07-04 08:50:47 UTC
Issue is introduced by Gerrit change #12713 "jquery.byteLimit: Partial rewrite to fix logic errors"
Comment 2 Antoine "hashar" Musso (WMF) 2012-07-04 08:51:59 UTC
Testswarm job for 12713
Comment 3 Siebrand Mazeland 2012-07-04 08:56:05 UTC
Will probably be reverted (Gerrit change #14175), so lowering priority.
Comment 4 Krinkle 2012-07-04 11:41:24 UTC
Debugging in Chrome, looks like it is not caused by jquery.byteLimit. The browser itself is limiting it.

The native maxLength property is being set to 0.

Turns out that if you set Element.maxLength = undefined; (implied by $input.removeProp('maxLength');) 
The property becomes undefined indeed in Chrome and Firefox. But the attribute value is changed to maxlength="0".

So the very code that was indented to disable te native maxLength ends up enforcing it even stronger. Will try to figure out a different solution then, and file a bug upstream.
Comment 5 Krinkle 2012-07-04 13:12:04 UTC
Revert has been merged.

I filed bug 38163 for the bug that I tried to solve in that commit.
Comment 6 Bergi 2012-09-13 19:09:56 UTC
That revert still did not fix the issue - the property is still set to undefined (resulting in zero) when there is a modifier function (Reported at

Gerrit change #23541 should solve that by fully removing the attribute.
Comment 7 Krinkle 2012-09-14 02:12:44 UTC
Fixed in I9c204243d0bdf7158aa86a62b591ce717a36fe27.
Comment 8 Bartosz Dziewoński 2012-09-21 15:30:32 UTC
This is not fixed, as neither patch is merged.
Comment 9 Sumana Harihareswara 2012-09-21 15:51:33 UTC
RobLa, since this is a pretty major problem for Firefox 13 & Chrome users (they simply cannot edit the edit summary box), it seems like this should block the next deployment. MatmaRex suggests we should merge the quick-fix changeset at while waiting for Krinkle to improve the more systematic fix.
Comment 10 Krinkle 2012-09-22 20:13:46 UTC
(In reply to comment #9)
> while waiting for Krinkle to improve the more systematic fix.

Done in I9c204243d0bdf7158aa86a62b591ce717a36fe27.
Comment 11 Mark A. Hershberger 2012-09-30 18:16:38 UTC
queued for merge to 1.20 tarball.
Comment 12 Sam Reed (reedy) 2012-10-01 12:49:27 UTC
(In reply to comment #11)
> queued for merge to 1.20 tarball.
Comment 13 Sam Reed (reedy) 2012-10-01 12:50:47 UTC
Oops, not actually merged yet..
Comment 14 Bartosz Dziewoński 2012-10-02 18:06:30 UTC
Merged now.
Comment 15 Sumana Harihareswara 2012-10-02 18:08:31 UTC
Thanks for nudging on this, Bartosz.
Comment 16 Krinkle 2012-10-02 18:21:29 UTC
.. and merged to 1.20.

Note You need to log in before you can comment on or make changes to this bug.