Last modified: 2012-12-13 11:17:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40145, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38145 - Data Item DOM for description & aliases should be integrated into existing DOM properly
Data Item DOM for description & aliases should be integrated into existing DO...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
storypoints: 8
:
Depends on: 39175
Blocks: 37771
  Show dependency treegraph
 
Reported: 2012-07-03 14:11 UTC by Daniel A. R. Werner
Modified: 2012-12-13 11:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2012-07-03 14:11:55 UTC
Right now we we are having quite a mess with how we have positioned different parts of the items which are placed around the heading. All parts (except for the heading which is fine) are placed beneath #bodyContent > #contentSub which is a bad thing since #contentSub is the part displayed beneath the pages title sometimes. It also creates a gap which we suppressed so far, but can't do that anymore since it would look strange on the diff site. Also, if there would ever be any information be displayed in the #contentSub on our Items page, this would break the layout since the information would be there in-between heading and description.
One more site-effect we could achieve by solving this would be that we could finally use the original separator line which is displayed under the title (right now we are creating our own one as workaround) - that would also be a benefit when supporting several different skins.

Here is what I think would solve the problem best:
Displaying the description above the #bodyContent but beneath the h1 heading. The aliases we would display either within #bodyContent > #contentSub or we would create another node above #contentSub or probably even better, above #siteSub.
#siteSub by the way displays the "From Wikipedia, the free encyclopedia" part in the English wikipedia which is displayed beneath the line under the page title as well. So in case there will be something like a "From Wikidata, the free data store", it would be best to go for the above #siteSub solution.
Comment 1 Daniel A. R. Werner 2012-08-08 11:40:53 UTC
I have introduced a new node to the vector and monobook skins, it is within the h1 now. See https://gerrit.wikimedia.org/r/#/c/17073

The node is WITHIN the h1 because when adding it next to the h1, css changes are inevitable (moving the line under the heading to the top of the #bodyContent). This would require hundreds of wikipedias to change their portal page because the line would be visible there while the h1 is hidden. Also users hiding this line would have to adjust their custom css.
Comment 2 denny vrandecic 2012-08-09 12:00:31 UTC
Implement the changes as decided in bug 39175.
Comment 3 Anja Jentzsch 2012-11-29 12:38:44 UTC
Verified in Wikidata demo time for sprint 12

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links