Last modified: 2014-03-14 22:21:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40129, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38129 - VisualEditor: Dialog to manipulate image properties (type, alignment, border, size, caption, alt text)
VisualEditor: Dialog to manipulate image properties (type, alignment, border,...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Moriel Schottlender
:
: 50709 51126 53937 (view as bug list)
Depends on:
Blocks: ve-mediasupport
  Show dependency treegraph
 
Reported: 2012-07-02 23:17 UTC by Brion Vibber
Modified: 2014-03-14 22:21 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-07-02 23:17:59 UTC
More for the wishlist...

Need a dialog to manipulate image properties (size, alignment, border, caption).
Comment 1 James Forrester 2013-05-12 01:54:54 UTC
Speculatively putting into the next release.
Comment 2 James Forrester 2013-06-19 01:02:53 UTC
Caption editing is now done and will be live in a few minutes; setting size, alignment, type and border will come later.
Comment 3 James Forrester 2013-07-04 01:22:39 UTC
*** Bug 50709 has been marked as a duplicate of this bug. ***
Comment 4 Maggie Dennis 2013-07-04 22:25:50 UTC
Just adding another urge for alt.text at English Wikipedia. :)
Comment 5 James Forrester 2013-07-10 18:42:49 UTC
*** Bug 51126 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2013-07-18 17:25:50 UTC
Change 74082 had a related patch set uploaded by Jforrester:
Base for media settings size widget.

https://gerrit.wikimedia.org/r/74082
Comment 7 Patrick Earley 2013-08-04 16:41:08 UTC
We have another request for "alt text" support in the media dialog.  As this is an accessibility concern for the visually impaired in our reader base, it's an important option to offer (the dialog will have to explain this field, and why it's desirable).
Comment 8 Gerrit Notification Bot 2013-11-06 17:34:17 UTC
Change 92767 had a related patch set uploaded by Jforrester:
[WIP] Add further image attribute editing to the media dialog

https://gerrit.wikimedia.org/r/92767
Comment 9 James Forrester 2013-11-06 17:34:30 UTC
*** Bug 53937 has been marked as a duplicate of this bug. ***
Comment 10 Gerrit Notification Bot 2014-01-03 22:12:52 UTC
Change 92767 abandoned by Mooeypoo:
[WIP] Add further image attribute editing to the media dialog

Reason:
Split into separate dependent commits

https://gerrit.wikimedia.org/r/92767
Comment 11 Gerrit Notification Bot 2014-01-14 05:26:19 UTC
Change 103193 had a related patch set uploaded by Jforrester:
Changing image size in MWMediaEditDialog

https://gerrit.wikimedia.org/r/103193
Comment 12 Gerrit Notification Bot 2014-01-14 05:26:39 UTC
Change 105098 had a related patch set uploaded by Jforrester:
Adding alternate text to media edit dialog

https://gerrit.wikimedia.org/r/105098
Comment 13 Gerrit Notification Bot 2014-01-23 02:57:44 UTC
Change 103193 merged by jenkins-bot:
Changing image size in MWMediaEditDialog

https://gerrit.wikimedia.org/r/103193
Comment 14 Gerrit Notification Bot 2014-02-06 02:59:23 UTC
Change 105098 merged by jenkins-bot:
Adding alternate text to media edit dialog

https://gerrit.wikimedia.org/r/105098
Comment 15 Gerrit Notification Bot 2014-02-06 03:24:09 UTC
Change 105247 had a related patch set uploaded by Jforrester:
[WIP] Add image type change to media edit dialog

https://gerrit.wikimedia.org/r/105247
Comment 16 James Forrester 2014-02-06 03:40:48 UTC
A quick review of the settings functionality for the media dialog right now:

* which media item is shown (but keeping other options): bug 51033
* media item type (thumb, frame, frameless): underway in Gerrit change #105247
** media thumbnail over-ride: not yet done, low priority
* border: not yet done, low priority
* location (left/right/centre/non): bug 51293, done
* alignment (baseline/middle/…): not yet done, low priority
* size: mostly done; needs some fixes
** need a "set at default size" button
** need a "set as 'upright'" value setting (default to 75%)
** logic rule changes when image is frame not thumb (no upscaling of image)
* link: not yet done, low priority
** Possibly needs to know licence to avoid linking in violation of licence, e.g. CC-BY?
* alt text: done
* caption: done

Non-image things:
* page (for multi-page items, e.g. PDFs): not yet done, low priority
* noicon (for multimedia items): not yet done, low priority
* start: not yet done, low priority
* thumbtime: not yet done, low priority

Other things:
* preview of media item: bug 52461
* remove from page button: bug 51764
* merging with the (future) gallery editing dialog: not yet done
* CE-surface fixes to make TMH's media items display correctly: not yet done
Comment 17 Gerrit Notification Bot 2014-02-08 00:45:50 UTC
Change 105247 merged by jenkins-bot:
Add image type change to media edit dialog

https://gerrit.wikimedia.org/r/105247
Comment 18 James Forrester 2014-03-06 05:11:52 UTC
Updated list of not-yet-done items from comment #16:

* which media item is shown (but keeping other options): bug 51033
* media thumbnail over-ride: not yet done, low priority
* alignment (baseline/middle/…): not yet done, low priority
* need a "set as 'upright'" size value setting (default to 75%)
* link: not yet done, low priority

Non-image things:
* page (for multi-page items, e.g. PDFs): not yet done, low priority
* noicon (for multimedia items): not yet done, low priority
* start: not yet done, low priority
* thumbtime: not yet done, low priority

Other things:
* preview of media item: bug 52461
* remove from page button: bug 51764
* merging with the (future) gallery editing dialog: not yet done
* CE-surface fixes to make TMH's media items display correctly: not yet done
Comment 19 James Forrester 2014-03-14 22:16:11 UTC
Moving all of these out into their own bugs and closing this:

(In reply to James Forrester from comment #18)
> * media thumbnail over-ride: not yet done, low priority

Now bug 62669.

> * alignment (baseline/middle/…): not yet done, low priority

Now bug 62670.

> * need a "set as 'upright'" size value setting (default to 75%)

Now bug 62671.

> * link: not yet done, low priority

Now bug 62672.

> Non-image things:
> * page (for multi-page items, e.g. PDFs): not yet done, low priority

Now bug 62673.

> * noicon (for multimedia items): not yet done, low priority

Now bug 62674.


> * start: not yet done, low priority

Now bug 62675.


> * thumbtime: not yet done, low priority

Now bug 62676.


> * merging with the (future) gallery editing dialog: not yet done

Now bug 62677.


> * CE-surface fixes to make TMH's media items display correctly: not yet done

Now bug 62678.

Closing this one as an unhelpful semi-tracker.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links