Last modified: 2013-06-29 13:21:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40103, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38103 - Gerrit: Links containing git hash are broken


Summary:	Gerrit: Links containing git hash are broken

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-01 20:44 UTC by Liangent
Modified:	2013-06-29 13:21 UTC (History)
CC List:	5 users (show)

See Also:	45780
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2012-07-01 20:44:16 UTC

See Gerrit change #13558.

In the mail I received it says:

Krinkle has posted comments on this change.

Change subject: Link to CREDITS file on message 'version-poweredby-others'
......................................................................


Patch Set 1:

Interesting, they made exception for that in wmf-config:

https://gerrit.wikimedia.org/r/gitweb?p=operations/mediawiki-config.git;a=tree;f=live-1.5;h=9d9075e78c775d9fd24637e2eea1fdfe29a6fb1f;hb=HEAD

I suppose we can simply expect sites to make this work, and wmf will have to add the exception for CREDITS there, like for COPYING. Please do so before merging this commit, to avoid a 404 error.

Comment 1 Krinkle 2012-07-01 20:45:28 UTC


*** This bug has been marked as a duplicate of bug 33437 ***

Comment 2 Krinkle 2012-07-01 20:48:57 UTC


*** This bug has been marked as a duplicate of bug 17006 ***

Comment 3 Krinkle 2012-07-01 20:50:47 UTC

Un-duping. Title seems confusing, what is the bug here?

Comment 4 Krinkle 2012-07-01 20:54:33 UTC

We introduced this ourselves with bug 36774, but due to a bug in gerrit it also runs on hyperlinks. The other comment-link parsers don't interfere with each other, but their linkifier is independent from this.


(Quote bug 36774 comment #5)
> [this] breaks links like
> 
> https://github.com/pediapress/mwlib/commit/4406d53b4c7dcd6cba8b7e5cf7076d08bf754f5c#docs/collection.rst
> 
> Filed http://code.google.com/p/gerrit/issues/detail?id=1451 upstream but in
> fact we should tweak the regular expression a bit. Maybe replace \\b with \\s+
> ?

*** This bug has been marked as a duplicate of bug 36774 ***

Comment 5 Krinkle 2013-04-24 17:52:58 UTC

Re-opening, this is broken again.

See https://gerrit.wikimedia.org/r/#/c/60681/:
> d1b4dcd6ac" target="_blank">https://github.com/joyent/node/commit/d1b4dcd6ac

Original text:
> https://github.com/joyent/node/commit/d1b4dcd6ac

Comment 6 Krinkle 2013-04-25 23:05:52 UTC

Not just in commit message, in inline comments as well.

See https://gerrit.wikimedia.org/r/#/c/58281/16/resources/jquery.chosen/chosen-sprite%25402x.png

> aa365247(v=vs.85).aspx" target="_blank">http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

Original text:
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

Comment 7 Matthew Flaschen 2013-06-19 06:56:53 UTC

Another example: http://stackoverflow.com/a/5371101

Comment 8 christian 2013-06-29 13:21:04 UTC

Looks like this was fixed by
https://gerrit.wikimedia.org/r/#/c/64502

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links