Last modified: 2013-10-09 02:48:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40081, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38081 - mediawiki.Title: Extension should be included when asserting that title is non-empty
mediawiki.Title: Extension should be included when asserting that title is no...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.19
All All
: High normal (vote)
: 1.22.0 release
Assigned To: Krinkle
:
: 51308 55493 55494 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-29 09:48 UTC by Daniel A. R. Werner
Modified: 2013-10-09 02:48 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2012-06-29 09:48:25 UTC 
Titles like ".dm" ( http://sah.wikipedia.org/wiki/.dm ) will throw an error when using the mw.Title constructor with them. Apparently mw.Title tries to be smart and treads this as a title with file extension. At least it enters mw.Title.setNameAndExtension() where the validation fails. '.123456' though will be accepted since the part behind the dot is longer than 5 characters.
Comment 1 Krinkle 2012-06-29 10:08:04 UTC 
Yeah, it shouldn't validate extensions because extensions are only an end-user convenience, no significant to them.

rephrasing summary to problem-solution orientation.
Comment 2 Krinkle 2013-09-05 01:06:37 UTC 
It fails because after stripping off the extension, the title is empty, which is invalid.
Comment 3 Gerrit Notification Bot 2013-09-06 00:40:03 UTC 
Change 83047 had a related patch set uploaded by Krinkle:
mw.Title: Rewrite from scratch (porting logic from Title.php)

https://gerrit.wikimedia.org/r/83047
Comment 4 Krinkle 2013-09-06 01:33:14 UTC 
*** Bug 51308 has been marked as a duplicate of this bug. ***
Comment 5 Andre Klapper 2013-09-26 14:46:03 UTC 
https://gerrit.wikimedia.org/r/#/c/83047/ needs review.
Comment 6 Gerrit Notification Bot 2013-10-04 03:24:01 UTC 
Change 83047 merged by jenkins-bot:
mw.Title: Rewrite from scratch (porting logic from Title.php)

https://gerrit.wikimedia.org/r/83047
Comment 7 James Forrester 2013-10-04 05:23:14 UTC 
Fixed and merged. Thank you hugely to Timo, and to Roan for merging. Yay.
Comment 8 James Forrester 2013-10-09 02:47:13 UTC 
*** Bug 55493 has been marked as a duplicate of this bug. ***
Comment 9 James Forrester 2013-10-09 02:48:11 UTC 
*** Bug 55494 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links