Last modified: 2013-12-16 19:05:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40029, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38029 - VisualEditor: Character inserter should re-use the code/config from WikiEditor somehow
VisualEditor: Character inserter should re-use the code/config from WikiEdito...
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Rob Moen
:
: 58323 (view as bug list)
Depends on: 50296
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-28 17:13 UTC by Brion Vibber
Modified: 2013-12-16 19:05 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-06-28 17:13:32 UTC
Inserting symbols, accented characters, and characters from other writing systems is a common task in encyclopedia-building.

VisualEditor needs to provide this as much as WikiEditor does; preferably they should use the same configuration and avoid duplicating code or config if possible.
Comment 1 James Forrester 2012-06-28 22:26:01 UTC
Agree with stealing existing code if possible. :-)
Comment 2 Rob Moen 2012-12-06 22:21:52 UTC
This may be obvious but to use the existing character code would make this feature dependent on WikiEditor.  Otherwise, reproduce the character configuration in a  VisualEditor module.  Another idea is to to pull the character configuration out of WikiEditor and place it in a more centralized place.  Thoughts?
Comment 3 Rob Moen 2012-12-06 22:23:18 UTC
the character config can be found: WikiEditor/modules/jquery.wikiEditor.toolbar.config.js
Comment 4 James Forrester 2012-12-06 23:11:54 UTC
Forking existing code feels icky, but depending on an otherwise-unrelated extension isn't a good way to go.

Possibly some of this could be core-ified?
Comment 5 Bill Skaggs 2013-07-12 14:18:57 UTC
I have a few comments; apologies if I misunderstand the issues or am commenting in the wrong place.

First, the ability to enter special characters should have higher priority.  They are very frequently used -- long dashes the most frequently of all, but many others too.

Second, the WikiEditor toolbar is probably overkill.  A better model may be the CharInsert gadget that can be enabled in the English Wikipedia preferences.  The JS code for the gadget can be found at

http://en.wikipedia.org/wiki/MediaWiki:Gadget-charinsert.js

The gadget depends on a very simple extension called CharInsert, whose php code can be viewed at

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCharInsert/8fa1602e22324b73491004957f02d5309302505b/CharInsert.php

Of course none of this can be used without modification, but it may provide a model for a character insert interface that has been optimized for usability.
Comment 6 pamdavies7 2013-07-17 13:15:55 UTC
This seems coincidentally to have been the subject of two separate requests today in the VE feedback pages: many editors need access to accented characters, greek letters, em-dashes and other specialised symbols, etc. See http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Quick_insert_panel and the section below it.
Comment 7 Chris McKenna 2013-08-05 15:29:44 UTC
Another request for this today. It's regarded as one of the few key missing features by a significant content editor.
Comment 8 James Forrester 2013-11-01 05:09:28 UTC
Re-wording this and making it depend on bug 50296 - I have doubts about this, however. Many choices about availability of characters, or about their prominence, aren't appropriate in both contexts ("~~~~" isn't something needed in VisualEditor, for example). Not sure whether this should instead be a WONTFIX in lieu of 50296, but leaving open for now.
Comment 9 James Forrester 2013-12-16 18:57:18 UTC
*** Bug 58323 has been marked as a duplicate of this bug. ***
Comment 10 James Forrester 2013-12-16 19:05:01 UTC
Re-visiting this, I'm not sure I agree with the premise any more.

Lots of the per-language localisations (and the per-wiki customisations) of the "edit tools" message have added useful characters for editors without the ability to insert them using their keyboard, but they all mix the semantic concepts of wikitext syntax fragments (e.g. "<nowiki>" or even "{{RLM}}") and accented characters; asking communities to de-merge these just so VisualEditor can re-use some of them seems impractical.

Consequently I'm going to mark this as a WONTFIX, but if you can think of a sane way to do this, please re-open. :-(

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links