Last modified: 2013-07-10 07:48:09 UTC
Magic links: RFC xxx stuff
Think this issue is going to be fixed by Parsoid as and when this is done. :-)
<nowiki>RFC 12234</nowiki> round-trips just fine in Parsoid (try it at http://parsoid.wmflabs.org/_rtform/), so I think this is a VE bug. Guessing the module, please change as needed.
Behaviour 1. Enter "RFC 1234" & save; it doesn't auto-nowiki, so you get a page with "RFC 1234" as wikitext which automatically links. 2. Edit again in VE; you get a link which you could edit. 3. Saving this without changing causes the link to be unchanged (as expected). 4. Saving this with a different link doesn't convert 5. Enter "<nowiki>RFC 1234</nowiki>" in wikitext editor, save. 6. Edit in VE; you get some text link in an alien node. 7. Saving this causes the link to be unchanged (as expected). Fixes for unexpected behaviours above: 1. This feels a little odd; should magic links be allowed, or should Parsoid (un?)magically wrap them in <nowiki>s? 2. This probably should be alienated in DM. 4. If the link won't be alienated (i.e., option 2 is not followed), we'll need to special-case this kind of link and re-generate [[]]s around it (? in DM).
Parsoid HTML+RDFa output for "RFC 1234" as wikitext input is: <a typeof="mw:ExtLink/RFC" href="//tools.ietfs.org/html/rfc1234" rel="mw:ExtLink/RFC" data-parsoid="{"tsr":[0,8],"dsr":[0,8]}">RFC 1234</a>
https://gerrit.wikimedia.org/r/37496 has a fix for this -- but there is more to be tested and done. Work-in-progress. Feel free to report additional failure test cases here.
Think there are still issues to resolve in DM (either options 1. or 2.) - Roan?
Pulling from release; we won't get to this.
(In reply to comment #4) > Behaviour > > 1. Enter "RFC 1234" & save; it doesn't auto-nowiki, so you get a page with > "RFC > 1234" as wikitext which automatically links. > 2. Edit again in VE; you get a link which you could edit. This is no longer true. The behavior on master is that the link gets alienated. > 3. Saving this without changing causes the link to be unchanged (as > expected). > 4. Saving this with a different link doesn't convert You can't do that, because it's an alien. You can remove it as a unit. Bolding it seems to work too, although there's a different bug that causes text to be cut off there, will investigate. > 5. Enter "<nowiki>RFC 1234</nowiki>" in wikitext editor, save. > 6. Edit in VE; you get some text link in an alien node. > 7. Saving this causes the link to be unchanged (as expected). > Also alienated. Entering "RFC 2822" into an existing paragraph causes Parsoid to <nowiki> the entire paragraph. > Fixes for unexpected behaviours above: > > 1. This feels a little odd; should magic links be allowed, or should Parsoid > (un?)magically wrap them in <nowiki>s? It does this now, although the entire paragraph is wrapped. > 2. This probably should be alienated in DM. It is now. > 4. If the link won't be alienated (i.e., option 2 is not followed), we'll > need > to special-case this kind of link and re-generate [[]]s around it (? in DM). Moot, because we have alienation working. Closing this bug as WORKSFORME. I saw a few weird issues while testing this, but they seem to be Parsoid serialization bugs not directly related to this bug, and I may have an out-of-date library again.
Not WORKSFORME; we actively did something that made this work (just, we didn't notice at the time). :-)
