Last modified: 2013-04-22 16:15:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39841, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37841 - Parsoid: Escape plaintext three-tildes ~~~ are expanded to signature unexpectedly
Parsoid: Escape plaintext three-tildes ~~~ are expanded to signature unexpect...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 39254
  Show dependency treegraph
 
Reported: 2012-06-22 18:43 UTC by Liangent
Modified: 2013-04-22 16:15 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-06-22 18:43:18 UTC
If I input ~~~, it's converted to my signature. If I input <nowiki>~~~</nowiki>, the nowiki tag is escaped and wrapped and ~~~ is still PST'ed.
Comment 1 James Forrester 2012-06-22 22:05:39 UTC
Mass-moving items into VisualEditor product
Comment 2 James Forrester 2012-06-23 00:56:40 UTC
Not sure this isn't intended behaviour. Roan?
Comment 3 Brion Vibber 2012-06-23 02:04:04 UTC
Tweaking summary so it's clear this is about how multiple-tilde strings are handled on save.
Comment 4 Roan Kattouw 2012-08-06 22:06:20 UTC
Actually a Parsoid issue, moving.
Comment 5 Gabriel Wicke 2012-08-06 22:37:38 UTC
We don't recognize tildes in the tokenizer yet, which would also be the reason why they are not yet escaped. Tildes are already included in syntactic stops used by urltext, but there is no production actually matching them. Should be relatively easy to add.

For regular Wikitext->HTML parsing, those tildes need to be converted back to plain text however (essentially ignored), as they are normally only processed in a pre-save transform. 

An alternative (and arguably simpler) solution would be a simple regexp-based escape rule in escapeWikitext.
Comment 6 Gabriel Wicke 2012-12-11 01:43:59 UTC
Patch committed in https://gerrit.wikimedia.org/r/37996

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links