Last modified: 2013-07-02 20:54:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39801, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37801 - LQT search function use the normal search, but adding ondiscussionpage:, exposing that keyword on the new page creation link
LQT search function use the normal search, but adding ondiscussionpage:, expo...
Status: RESOLVED DUPLICATE of bug 22678
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
master
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-21 19:05 UTC by DaSch
Modified: 2013-07-02 20:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description DaSch 2012-06-21 19:05:08 UTC
Somehow sometimes instead of the korrekt Thread:Topic pages there are strang
Topic ondiscussionpage:Talk_Page:Pagename are created.

This is on MW 1.20 with latest git clone of LQT
Comment 1 matanya 2012-06-21 20:35:27 UTC
Can you please add some screenshots, and describe exactly what are the steps causing this?
Comment 2 DaSch 2012-06-22 16:43:30 UTC
The problem is, that I can not reproduce this problem myself. I just see some users randomly create such strange pages on my Wiki.

I can enter some example pagenames, there is nothing more to see. And I deleted the pages after this.

Examples

Looser ondiscussionpage:Benutzer Diskussion:DaSch
Roter Laternenbaum ondiscussionpage:WeCoWi:Importanfragen
Gualterio Looser Schallemberg ondiscussionpage:WeCoWi:Importanfragen
Lemma Manfred Riebe ondiscussionpage:Benutzer Diskussion:Manfred Riebe
Rockya ondiscussionpage:Benutzer Diskussion:DaSch
Comment 3 Andre Klapper 2012-12-18 18:33:41 UTC
DaSch: Has this ever happened again? If not this is probably a RESOLVED WORKSFORME...
Comment 4 DaSch 2012-12-25 17:45:38 UTC
in the last month not. But LQT was not used that much in the last month. I assign this to me so that I'll keep an eye on this
Comment 5 DaSch 2013-06-09 10:31:20 UTC
so this happended again
Skin-Extensions ondiscussionpage:Portal:Gästebuch

the format is always the same. It's <Threadname> ondiscussionpage:<Discussionpagename>

I think that this may be a JavaScript Error, that maybe happens with old Browsers.
Comment 6 Jesús Martínez Novo (Ciencia Al Poder) 2013-06-09 10:48:28 UTC
Oh, I think I see what's happening here.

1. Go to https://www.mediawiki.org/wiki/Project:Support_desk
2. There's a search box just above the LQT TOC. Put anything there and hit
   the "search" button (for example, "testing")
3. The search results page comes up. The search terms are:
    testing ondiscussionpage:Project:Support desk
4. Below the search filters there's a "Create the page "Testing
   ondiscussionpage:Project:Support desk" on this wiki!" with a link to create
   "Testing ondiscussionpage:Project:Support desk" (MediaWiki:Searchmenu-new)

People clicking on that link will be creating that page as any other normal page.

Maybe we should change that new page creation link to point to a new thread creation (under the original discussion, stripping ondiscussionpage:) instead of the default one. Or remove the link to create that page completely, probably using a different message than MediaWiki:Searchmenu-new.
Comment 7 Alex Monk 2013-06-09 13:27:32 UTC
So it turns out this 'ondiscussionpage' thing is coded into Wikimedia's Lucene Search - 'inthread' as well. See operations/debs/lucene-search-2.git
Comment 8 Jesús Martínez Novo (Ciencia Al Poder) 2013-06-09 13:30:18 UTC
The ondiscussionpage: "feature" was added on r53948 but it's undocumented.
"It requires Lucene search to be installed." according to comments for that commit. Still, no documentation about what configuration needs for Lucene search.

Also, lowering severity
Comment 9 Andre Klapper 2013-06-11 18:04:53 UTC
So shall this request be moved to "Wikimedia > lucene-search-2" or is there something that can be fixed in the LQT codebase?
Comment 10 Alex Monk 2013-06-11 21:14:18 UTC
I really have no idea. MediaWiki core should have a system to detect such keywords (or whatever you call the 'ondiscussionpage' thing), know which ones lucene supports, and run the right hooks. And then LQT should be able to use this hook to determine whether or not to show the page creation link.
Comment 11 Alex Monk 2013-07-02 20:54:53 UTC

*** This bug has been marked as a duplicate of bug 22678 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links