Last modified: 2013-10-17 03:40:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39714, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37714 - [Regression] Incomplete log entries: sublog missing
[Regression] Incomplete log entries: sublog missing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
1.20.x
All All
: Normal major (vote)
: 1.20.x release
Assigned To: Alex Monk
: code-update-regression
Depends on:
Blocks: revdel
  Show dependency treegraph
 
Reported: 2012-06-19 14:50 UTC by MA
Modified: 2013-10-17 03:40 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
federicoleva: Backport_to_Stable+


Attachments

Description MA 2012-06-19 14:50:45 UTC
Hello,

The log entries generated when using Revision Deletion on logs are now incomplete and looks like:


     (show/hide) 21:11, 16 June 2012 MarcoAurelio (talk | contribs | block) changed visibility of a log event on Special:Log: content hidden (hiding vandalism/attack) (change visibility)  

Previously:


    (show/hide) 22:04, 9 March 2012 MarcoAurelio (talk | contribs | block) changed visibility of a log event on Special:Log/globalauth: content hidden (username) (change visibility)


Please restore in the message on which sublog the action was performed; which has been recently removed as far as I can see.

Thanks.
Comment 1 Platonides 2012-06-19 15:48:14 UTC
I guess it appeared yesterday with 1.20wmf5 release?
Comment 2 Platonides 2012-06-19 15:52:27 UTC
Last event with log subpage was 20120508192229, so it'd be a 1.20wmf4 regression, not 1.20wmf5
Comment 3 Alex Monk 2012-06-19 16:09:09 UTC
I think this is because you can now select multiple log entries - and therefore multiple types of log. You'll see the same thing on Special:RevisionDelete - it only shows 'Logs'. Maybe if all the hidden entries are of one type, it should show that type?
Comment 4 Rob Lanphier 2012-10-12 16:07:46 UTC
Removing this as a blocker for future deployments, since rolling back to the previous version will not fix this issue.
Comment 5 Krinkle 2012-10-13 04:44:48 UTC
(In reply to comment #4)
> Removing this as a blocker for future deployments, since rolling back to the
> previous version will not fix this issue.

I've marked it as 1.20 regression instead (which it is). For now also put on milestone, but depending on the severity it may not deserve a blocker, but it is a 1.20 regression that should ideally be fixed before it goes out in a public release.
Comment 6 Alex Monk 2012-10-13 13:53:44 UTC
Gerrit change #27869
Comment 7 Andre Klapper 2012-10-22 18:18:55 UTC
Patch needs one more review in Gerrit, help welcome.
Comment 8 Andre Klapper 2012-11-19 14:35:50 UTC
Patch has received two +1's, still not in though.
Comment 9 Alex Monk 2012-12-25 20:50:01 UTC
Merged by Chris on the 14th.
Comment 10 Alex Monk 2013-01-06 17:45:49 UTC
The maintenance script in Gerrit change #42405 can be used to fix deletion/suppression log entries which under the current system should have the target sublog.
Comment 11 Nemo 2013-04-13 07:12:32 UTC
Was already in the tarball and was then backported to 1.20 with https://gerrit.wikimedia.org/r/#/c/32227/
Comment 12 Alex Monk 2013-09-21 18:17:01 UTC
(In reply to comment #10)
> The maintenance script in Gerrit change #42405 can be used to fix
> deletion/suppression log entries which under the current system should have
> the
> target sublog.

Opened bug 54435 to have this run on WMF wikis
Comment 13 Alex Monk 2013-10-16 17:04:15 UTC
Which has now been done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links