Last modified: 2012-12-13 11:17:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39689, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37689 - Prevent direct editing of JSON via the APIs edit action
Prevent direct editing of JSON via the APIs edit action
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Daniel Kinzler
storypoints: 2
:
Depends on: 37779
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-18 14:21 UTC by Daniel Kinzler
Modified: 2012-12-13 11:17 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-06-18 14:21:18 UTC
The API's edit section allows editing of page content, using the serialized form for non-text content models(*). This should not be permitted for Wikidata entities, where specialized modules must be used. It may be the case that we have to modify a  few bits in the core API to make this work nicely.

(*) ApiEditPage is not yet aware of ContentHandlers, but this will be implemented in the next few days.
Comment 1 Nikola Smolenski 2012-06-18 14:37:45 UTC
Perhaps this could be implemented by each content handler having a function like isHumanEditable() which would say whether this is possible, whether there should be edit button etc.
Comment 2 Daniel Kinzler 2012-06-18 15:19:22 UTC
Being human-editable and allowing direct modification of the serialized form are two different things - one might want to allow direct modification even of non-human-readable content, for example SVG.

But yes, I think the ContentHandler should have functions to check for this.
Comment 3 jeblad 2012-07-04 16:26:57 UTC
Editing via API is blocked for this extension, should perhaps have a more generic solution. https://gerrit.wikimedia.org/r/#/c/13191/
Comment 4 Anja Jentzsch 2012-11-29 12:38:17 UTC
Verified in Wikidata demo time for sprint 8

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links