Last modified: 2013-08-10 18:20:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39483, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37483 - ProofreadPage extension should handle its namespaces in a more sensible manner
ProofreadPage extension should handle its namespaces in a more sensible manner
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Unprioritized normal with 1 vote (vote)
: ---
Assigned To: Tpt
: patch-need-review
Depends on:
Blocks: Wikisource 44320 52708 52709
  Show dependency treegraph
 
Reported: 2012-06-12 08:10 UTC by Beau
Modified: 2013-08-10 18:20 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Beau 2012-06-12 08:10:51 UTC
Current configuration of ProofreadPage extension involves:
- manually creating required namespaces
- updating pages in MediaWiki namespace to point at those namespaces

The extension should configure its namespaces automatically. It should use English names as canonical ones and localized ones visible to users. It should also try to use the same namespace numbers, but this should be configurable if there are collisiions.
Comment 1 Tpt 2012-08-04 12:30:52 UTC
Patch submit: https://gerrit.wikimedia.org/r/#/c/17643/
Comment 2 Tpt 2012-10-29 18:08:45 UTC
Patch merged.
Comment 3 Nemo 2013-01-19 19:46:16 UTC
Are now all the namespace aliases for Wikisources redundant?
[[oldwikisource:User:Nemo_bis/wgNamespaceAliases]]
Comment 4 Tpt 2013-01-19 20:42:02 UTC
No, they aren't because:
1 Author namespace is not managed by ProofreadPage
2 The extension doesn't add aliases if the namespace is created in the wiki configuration an not by the extension.

A thing to do is maybe to remove creation of page and index namespaces in $wgExtraNamespaces in order to let the extension create namespaces and, so, create aliases.
Comment 5 Nemo 2013-01-19 20:46:36 UTC
(In reply to comment #4)
> No, they aren't because:
> 1 Author namespace is not managed by ProofreadPage

Yes, I meant for Page: and Index:

> 2 The extension doesn't add aliases if the namespace is created in the wiki
> configuration an not by the extension.
> 
> A thing to do is maybe to remove creation of page and index namespaces in
> $wgExtraNamespaces in order to let the extension create namespaces and, so,
> create aliases.

So I guess this works only for namespaces with standard numbers? If yes, it's better to have redundant $wgExtraNamespaces and $wgNamespaceAliases than a config with partial info.
Comment 6 Tpt 2013-01-24 18:32:20 UTC
If the namespaces related to numbers sets in $wgProofreadPageNamespaceIds don't exist, the Proofread Page extension create these namespaces with the numbers set in $wgProofreadPageNamespaceIds with labels stored in i18n of the extension.

So, Proofead Page can create namespaces with not standard numbers if $wgProofreadPageNamespaceIds is correctly setup.

So, 
$wgLanguageCode = 'fr';
$wgProofreadPageNamespaceIds = array(
    'page' => 102,
    'index' => 104
);
will setup the same namspaces with the same ids as
$wgLanguageCode = 'fr';
$wgProofreadPageNamespaceIds = array(
    'page' => 102,
    'index' => 104
);
$wgExtraNamespaces[102] = 'Page';
$wgExtraNamespaces[104] = 'Livre';
$wgNamespaceAliases[102] = 'Page';
$wgNamespaceAliases[104] = 'Index';
Comment 7 Nemo 2013-01-24 19:15:05 UTC
Thank for the explanation, I'll ensure it's copied to the extension page (if it was already, excuse me).

I see $wgProofreadPageNamespaceIds defined in the WMF config, so indeed a cleanup there should be feasible. Can you file a bug so that we don't forget?
Comment 8 Nemo 2013-08-10 10:00:02 UTC
(In reply to comment #7)
> Thank for the explanation, I'll ensure it's copied to the extension page (if
> it
> was already, excuse me).
> 
> I see $wgProofreadPageNamespaceIds defined in the WMF config, so indeed a
> cleanup there should be feasible. Can you file a bug so that we don't forget?

That's bug 44320 but it has no updates in last month.
Also, does Proofread Page automatically add its namespaces to $wgNamespacesToBeSearchedDefault and $wgContentNamespaces ? That's an easily overloooked but very important piece of configuration and I find some numbers in WikiStats suspicious even after http://lists.wikimedia.org/pipermail/analytics/2013-August/000850.html
Comment 9 Tpt 2013-08-10 15:28:23 UTC
Sorry, I was busy in June and beginning of July so I haven't worked on it and now I'm in holidays. I'll make the cleaning in September.

No, Proofread Page doesn't automatically add its namespaces to
$wgNamespacesToBeSearchedDefault and $wgContentNamespaces. About $wgNamespacesToBeSearchedDefault I'm not sure it's a good idea to add Page: and Index: namespaces to it by default as most of Wikisources doesn't add the Page: namespace to $wgNamespacesToBeSearchedDefault. OK for $wgContentNamespaces. Feel free to open a new bug about it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links