Wikimedia Bugzilla is closed!

and it's broken now:

[76e38684] 2012-08-24 08:14:11: Fatal exception of type MWException

(In reply to comment #1)
> and it's broken now:
> 
> [76e38684] 2012-08-24 08:14:11: Fatal exception of type MWException

on zhwiki.

It's not broken, it's been disabled since March, see <https://wikitech.wikimedia.org/index.php?title=Server_admin_log/Archive_20&diff=44913&oldid=44912&diffonly=yes>. But bug 38095 strikes again.

Note: "PrefSwitch is needed by SimpleSurvey" <https://wikitech.wikimedia.org/index.php?title=Server_admin_log&diff=45462&oldid=45454&diffonly=yes>

(In reply to comment #3)
> It's not broken, it's been disabled since March, see
> <https://wikitech.wikimedia.org/index.php?title=Server_admin_log/Archive_20&diff=44913&oldid=44912&diffonly=yes>.
> But bug 38095 strikes again.
> 
> Note: "PrefSwitch is needed by SimpleSurvey"
> <https://wikitech.wikimedia.org/index.php?title=Server_admin_log&diff=45462&oldid=45454&diffonly=yes>

http://en.wikipedia.org/wiki/Special:PrefSwitch is showing something but http://zh.wikipedia.org/wiki/Special:PrefSwitch?uselang=en says

Internal error
[7788dd6f] 2012-08-24 09:25:17: Fatal exception of type MWException

(In reply to comment #4)
> http://en.wikipedia.org/wiki/Special:PrefSwitch is showing something but
> http://zh.wikipedia.org/wiki/Special:PrefSwitch?uselang=en says
> 
> Internal error
> [7788dd6f] 2012-08-24 09:25:17: Fatal exception of type MWException

It's the opposite for me. Ok, so this is another bug depending on your personal situation (aka just standard PrefSwitch brokenness).

(In reply to comment #5)
> It's the opposite for me. Ok, so this is another bug depending on your personal
> situation (aka just standard PrefSwitch brokenness).

Yeah but is such a semi-abandoned(?) and unmaintained extension worth fixing? If SimpleSurvey is only depending on a component of it, say, some functions in a class of PrefSwitch, it would be better to move it to SimpleSurvey and uninstall PrefSwitch.

(In reply to comment #3)
> Note: "PrefSwitch is needed by SimpleSurvey"
> <https://wikitech.wikimedia.org/index.php?title=Server_admin_log&diff=45462&oldid=45454&diffonly=yes>

No idea what SimpleSurvey does, but is that actually being used? If not, let's just get rid of both?

(In reply to comment #7)
> (In reply to comment #3)
> > Note: "PrefSwitch is needed by SimpleSurvey"
> > <https://wikitech.wikimedia.org/index.php?title=Server_admin_log&diff=45462&oldid=45454&diffonly=yes>
> 
> No idea what SimpleSurvey does, but is that actually being used? If not, let's
> just get rid of both?

They seem to have weird circular dependencies on each other.

AFT (original) has a dependency on SimpleSurvey:

/* XXX: Survey setup */
require_once( dirname( dirname( __FILE__ ) ) . '/SimpleSurvey/SimpleSurvey.php' );

which also includes PrefSwitch...

However, I can't seem to find any actual usages in the code...


I believe there is talk to disable legacy

I've made https://gerrit.wikimedia.org/r/26652 to remove them...

There are usages. Pfft

For reference, one usage is AFT's ext.articleFeedback.js loads a survey object from
<http://en.wikipedia.org/w/index.php?title=Special%3ASimpleSurvey&survey=articlerating&raw=1>

And the generated SimpleSurvey loads PrefSwitch/modules/ext.prefSwitch.js which provides some show/hide logic.  That one JS file should be moved to SimpleSurvey since the rest of Extension:PrefSwitch is ridiculously obsolete.

But since March 2012 AFT doesn't present its survey to anyone (it's weighted 0, so everyone only gets a "Did you know that you can edit this page?" pitch).  https://gerrit.wikimedia.org/r/26927 removes the survey code from AFT, which may allow SimpleSurvey and PrefSwitch to be killed.

Gerrit change #26927 was merged in time for 1.21wmf1, so AFT no longer requires SimpleSurvey.php which required PrefSwitch.php, so both extensions are gone from en-wiki. Yay!