Last modified: 2013-05-19 12:16:05 UTC
Following up on 33390, 24186, and 25898: searching for log entries from a private filter on EN currently doesn't display an error message. Instead it displays the log entries from all public filters. It would be better to display an error message instead, as described in 25898. Also, it looks to me like the solution to 25898 has become unfixed, since I get no error message and instead get redirected to the public logs, with the incorrect message at the top of the screen "This log shows a list of all actions that tripped a filter...."
Thank you for your bug report. Could you confirm the following steps to reproduce the bug on a test MediaWiki + AbuseFilter install are the right ones? # login with an unprivileged account # create a new filter # mark it public # logout and login with an unprivileged account # try to search his log entries # get it # logout and login with a privileged account # mark it private # logout and login with an unprivileged account # try to search his log entries # instead an error message, we'll get all the results of all the public filters Please also reopen bug #25898 to discuss the "unfixing" issue, this discussion doesn't belong here. Adding "see also" bug URLs.
Hi Dereckson, I can't reopen bugs because I currently lack the required permissions here on Wikimedia Bugzilla. Here are some sample steps to reproduce this bug. # Use an unprivileged account. # Go to https://en.wikipedia.org/wiki/Special:AbuseFilter to see a list of active public and private filters. Note which filters are public and which are private. # Go to https://en.wikipedia.org/wiki/Special:AbuseLog # In the "Filter ID" field, type the number of a private filter. # You now see a list of all logged entries from public filters, which is not the desired behavior. Note that if you instead do the following: # Use an unprivileged account # Go to https://en.wikipedia.org/wiki/Special:AbuseFilter to see a list of active public and private filters. Note which filters are public and which are private. # Click on the name or number of a private filter, such as by clicking "Prodego's test filter". # You get an error message as should be expected. Does this help?
So, in short: When filtering to a private filter in Special:AbuseLog, all public logs are shown instead of getting an error.
Confirming bug. I know this exists, basically a private abuse filter will have private logs but looking at the log view of the filter will show you the public log entries instead of saying you don't have permission to view the logs of the private filter. Previous bug to implement private filter logs was https://bugzilla.wikimedia.org/show_bug.cgi?id=33380.
Bug #25898 reopened, per description, comment #1 and comment #2.
Closed again, cf. bug 25898 comment 3.
Gerrit change #11826
Change abandoned: I've thought through this a lot more and it seems that someone should try to make sure that filtering by a private AbuseFilter work properly instead of just erroring like I suggested there.