Last modified: 2012-09-19 20:57:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39304, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37304 - [Regression] Pipe trick broken in PST
[Regression] Pipe trick broken in PST
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: High blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks: 37346
  Show dependency tree / graph
 
Reported: 2012-06-02 14:37 UTC by Krinkle
Modified: 2012-09-19 20:57 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2012-06-02 14:37:04 UTC 
As of 1.20wmf4 the pipe trick is broken. It works in preview but it doesn't work on save.

* broken:
  https://www.mediawiki.org/w/index.php?title=MediaWiki:Sandbox&oldid=545835

* works:
  http://nl.wikipedia.org/w/index.php?title=MediaWiki:Sandbox&oldid=31298893
Comment 1 Rob Lanphier (RobLa) 2012-06-02 16:21:19 UTC 
Tim is looking at this now.
Comment 2 Tim Starling 2012-06-02 16:37:23 UTC 
Siebrand's suggestion: https://gerrit.wikimedia.org/r/#/c/9850/
Comment 3 Krinkle 2012-06-05 15:27:55 UTC 
Moving to Wikimedia component since this is not an issue in MediaWiki core.

Keeping open until this is fixed.

Recommending we set wgTranslateDisablePreSaveTransform= true in wmf-config in/before 1.20wmf5 deployment (or do it right now?). If that is not possible (e.g. because the Translate extension needs it), then Gerrit change #9850 maybe isn't useful?
Comment 4 Krinkle 2012-06-13 14:26:39 UTC 
Pending review: I7cf6bdf1

https://gerrit.wikimedia.org/r/11155
Comment 5 Krinkle 2012-06-25 00:16:48 UTC 
Both the change by Tim implementing option and my change in wmf-config to enable it are merged. But the bug is still happening. Open comment #1 links. I tried re-saving them too.
Comment 6 Niklas Laxström 2012-06-25 06:19:38 UTC 
Funny. We discourage negative configuration options, and then you introduce one and get the values backwards, twice. I wonder if this has messed up some messages in twn.
Comment 7 Krinkle 2012-06-25 14:10:05 UTC 
(In reply to comment #6)
> Funny. We discourage negative configuration options, and then you introduce one
> and get the values backwards, twice. I wonder if this has messed up some
> messages in twn.

Nice catch!

Fix for extensions/Translate: Ie71f716afa331370358470560274720aa662f4a9
Update wmf-config: Ied0e671286d50866f8eba4a9cb1a0f1e64472a0f
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links