Last modified: 2012-12-30 20:41:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39159, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37159 - sqlite: DatabaseBase::delete and DatabaseBase::update return ResultWrapper object
sqlite: DatabaseBase::delete and DatabaseBase::update return ResultWrapper ob...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: sqlite
  Show dependency tree / graph
 
Reported: 2012-05-28 13:17 UTC by Jeroen De Dauw
Modified: 2012-12-30 20:41 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jeroen De Dauw 2012-05-28 13:17:54 UTC 
DatabaseBase::delete and DatabaseBase::update should always return a boolean, this is what the docs state and what appears to be happening when using MySQL. However, when using sqlite to run some of my tests (that run fine with MySQL), I'm getting some failures because I'm getting back a ResultWrapper object.

See failing test here: https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Misc/1446/console
Comment 1 Jeroen De Dauw 2012-05-28 15:09:08 UTC 
Installed sqlite and could reproduce locally.

Did some debugging, and found that the DB abstraction layer is riddled with inconsistencies in return types. Just have a look at DatabaseBase::doQuery and it's implementations in DatabaseMysql and DatabaseSqlite.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links