Last modified: 2012-06-05 17:50:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39138, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37138 - Search not working correctly on the "Database error" page (Google sitesearch doesn't support protocol relative urls)
Search not working correctly on the "Database error" page (Google sitesearch ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.19
All All
: Normal normal (vote)
: 1.20.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2012-05-27 13:22 UTC by Krinkle
Modified: 2012-06-05 17:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-05-27 13:22:41 UTC
Both the `domains` and the `sitesearch` query parameters are currently protocol-relative. Google only allows naked hostnames or full hostnames with protocol.

We should probably be passing the canonical server there.

Dump:

<!-- SiteSearch Google -->
<form method="get" action="//www.google.com/search" id="googlesearch">
	<input type="hidden" name="domains" value="//commons.wikimedia.org" />
	<input type="hidden" name="num" value="50" />
	<input type="hidden" name="ie" value="UTF-8" />
	<input type="hidden" name="oe" value="UTF-8" />

	<input type="text" name="q" size="31" maxlength="255" value="" />
	<input type="submit" name="btnG" value="Search" />
  <div>
	<input type="radio" name="sitesearch" id="gwiki" value="//commons.wikimedia.org" checked="checked" /><label for="gwiki">Wikimedia Commons</label>
	<input type="radio" name="sitesearch" id="gWWW" value="" /><label for="gWWW">WWW</label>
  </div>
</form>
<!-- SiteSearch Google -->

Example url from submitting "test" with "Commons Wikimedia":

https://www.google.com/search?domains=%2F%2Fcommons.wikimedia.org&num=50&ie=UTF-8&oe=UTF-8&q=test&btnG=Search&sitesearch=%2F%2Fcommons.wikimedia.org

(which just searches the entire web)
Comment 2 Krinkle 2012-06-05 17:49:53 UTC
Fixed in I31dc64f83ce8767dcdd84597844b0819840f60e1.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links