Last modified: 2012-08-05 16:19:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39085, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37085 - "Drag to new location" broken. Uncaught TypeError: Cannot read property 'length' of undefined
"Drag to new location" broken. Uncaught TypeError: Cannot read property 'leng...
Status: RESOLVED DUPLICATE of bug 31809
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-24 13:14 UTC by Helder
Modified: 2012-08-05 16:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2012-05-24 13:14:11 UTC
On function "submitDragDrop", there is a line[1] like this
----
if ( params.subject.length == 0 ) {
----

but when I follow the steps to drag a comment to a new location[2] (on a page such as [3]), it causes this error:
----
Uncaught TypeError: Cannot read property 'length' of undefined lqt.js:1553
window.liquidThreads.submitDragDrop lqt.js:1553
buttons.(anonymous function) lqt.js:1420
(anonymous function) jquery.ui.dialog.js:392
jQuery.event.dispatch load.php:3332
jQuery.event.add.elemData.handle.eventHandle load.php:2941
XHR finished loading: "https://www.mediawiki.org/w/api.php?action=query&list=threads&thid=13985&format=json&thprop=id%7Csubject%7Cparent%7Cmodified". 
----

I was using Google Chrome 19.0.1084.46 when I tested.

BTW: instead of "length == 0" it should be "length === 0".

[1] Last touched by Thomas: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LiquidThreads.git;a=blobdiff;f=lqt.js;h=27127208707f44cdb586b855721f872afeb3bfb2;hp=fc516a01ba37f1cc9690ea04027a89e9cde4370b;hb=dd6f8fcd258a47f863d2a8c5930eae3a3b1ded70;hpb=3d62392a67b0499a67c6db226081206016288fad
[3] https://www.mediawiki.org/wiki/Thread:Talk:Berlin_Hackathon_2012/Ops_sprint?debug=1
Comment 1 Helder 2012-05-24 13:16:05 UTC
(In reply to comment #0)
> ... the steps to drag a comment to a new location[2]

[2] See bug 37086 comment 0
Comment 2 Krinkle 2012-05-24 15:02:17 UTC
This exception has been breaking "Drag to new location" since late 2011.
Comment 3 Helder 2012-08-05 16:19:05 UTC

*** This bug has been marked as a duplicate of bug 31809 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links