Last modified: 2013-03-22 09:58:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39047, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37047 - gerrit-wm no more notify on comment or merge
gerrit-wm no more notify on comment or merge
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 35427
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 09:43 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-03-22 09:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-05-23 09:43:08 UTC
gerrit-wm no more notify when a comment is added to a change :(
Comment 1 Chad H. 2012-05-23 11:08:00 UTC
I thought we wanted to silence the bot on new comments? See bug 35427.
Comment 2 Antoine "hashar" Musso (WMF) 2012-05-23 13:11:53 UTC
(In reply to comment #1)
> I thought we wanted to silence the bot on new comments? See bug 35427.

And:
"New Review" should be sent to #mediawiki-codereview

Anyway, I think the lack of comment is a side effect of some change or a bug and that was not intentionally done. Hence this bug request ;-]
Comment 3 Antoine "hashar" Musso (WMF) 2012-05-23 14:34:43 UTC
It is also missing notifications on merge which make that bugs very annoying.
Comment 4 Ryan Lane 2012-05-23 23:30:20 UTC
Fixed in I97619c05 and Ic69da7d4.
Comment 5 Antoine "hashar" Musso (WMF) 2012-05-24 05:38:49 UTC
(In reply to comment #4)
> Fixed in I97619c05 and Ic69da7d4.

Ryan, can you possibly paste the Gerrit URLs instead so we just have to click ? ;-D Good catch by the way!

https://gerrit.wikimedia.org/r/8726
https://gerrit.wikimedia.org/r/8727

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links