Last modified: 2013-08-12 15:20:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38755, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36755 - gallery should not use ul/li
gallery should not use ul/li
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.20.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 23932
  Show dependency treegraph
 
Reported: 2012-05-11 07:14 UTC by Fomafix
Modified: 2013-08-12 15:20 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fomafix 2012-05-11 07:14:27 UTC
Gallery generate at the moment an unnumbered list containing the images. In the browser the bullets are hidden by CSS. When you open copy a gallery from web page to a word processing you get a unnumbered list with annoying bullets.

The unnumbered list is for semantical reasons not necessary. For HTML4 with div/div instead of ul/li should be satisfactorily and has no disadvantages.

For HTML5 the figure element would be the right element:
http://www.w3.org/TR/html5/the-figure-element.html#the-figure-element

<gallery title="Caption">
File:Image1.jpg|First Image
File:Image2.jpg|Second Image
</gallery>

<figure class="gallery">
 <figcaption>Caption</figcaption>
 <figure>
  <img src="Image1.jpg" />
  <figcaption>First Image</figcaption>
 </figure>
 <figure>
  <img src="Image2.jpg" />
  <figcaption>Second Image</figcaption>
 </figure>
</figure>
Comment 1 Gerrit Notification Bot 2013-05-03 23:14:34 UTC
Related URL: https://gerrit.wikimedia.org/r/62207 (Gerrit Change Ida8ed0436626d3455b7d28ebac7c8fc6e0b47acd)
Comment 2 Matthew Flaschen 2013-06-04 03:27:18 UTC
This is a special case of bug 23932.  Apparently, styling such tags (new to HTML5) works pretty much everywhere, except IE before 9 *without JS*.  The last consensus at 23932 was that we still need to worry about that.  Anyway, we should probably determine a broad course there rather than doing this piecemeal.
Comment 3 Derk-Jan Hartman 2013-08-12 15:20:46 UTC
I disagree with the part of the premise of this ticket and the 
solution that was identified.

If your copy paste gives you something ugly, then that's a bug in your copy paste, not in the definition of the html structure.

If you want to wrap the blocks in figures, then that would be nice, but it doesn't replace the original intent of using ul and li. It's just one of many ways to loose ugly bullet points, but in terms of structure, other then being html5, it's not necessarily better.

The gallery is semantically a list in at least Special:NewFiles and Category pages and actually using a list for it has benefits for assistive technology in these cases. Now I guess there could be made a case that inside articles, our gallery aren't really lists but rather groups of images, but then we should split the gallery generator into two modes that can work independent of eachother.

Using figure and figcaption are totally independent issues as far as i'm concerned. They are just div's with extra meaning.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links