Last modified: 2012-11-10 17:29:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38655, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36655 - Add unit tests for ForeignAPIRepo
Add unit tests for ForeignAPIRepo
Status: NEW
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 41978 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-08 17:53 UTC by Siebrand Mazeland
Modified: 2012-11-10 17:29 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2012-05-08 17:53:10 UTC 
This functionality needs to be added to the MediaWiki core unit tests, as many use it to get images from Wikimedia Commons available in their wiki. See bug 36653.
Comment 1 Antoine "hashar" Musso (WMF) 2012-05-09 05:42:19 UTC 
So do we want to have tests for instant commons (original request) or for ForeignAPIRepo (per Krinkle) ?  

Is the brokeness caused by some bug in ForeignAPIRepo?
Comment 2 Krinkle 2012-05-09 06:42:06 UTC 
The recent breakage was caused by a bug in the central Http classes (almost no outgoing http requests were working at all, including those made by ForeignAPIRepo).

wgUseInstantCommons is just a shortcut for Setup.php to add a $wgForeignFileRepos using ForeignAPIRepo to link with http://commons.wikimedia.org/w/api.php
Comment 3 Chad H. 2012-05-09 17:18:44 UTC 
(In reply to comment #2)
> The recent breakage was caused by a bug in the central Http classes (almost no
> outgoing http requests were working at all, including those made by
> ForeignAPIRepo).
> 

We should introduce some sane tests for this then. The last versions were doing a bunch of external requests to sites we don't control.

(In reply to comment #1)
> So do we want to have tests for instant commons (original request) or for
> ForeignAPIRepo (per Krinkle) ?  
>

Presumably the latter, but perhaps using Commons as the test repo.
Comment 4 Umherirrender 2012-11-10 17:29:10 UTC 
*** Bug 41978 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links