Last modified: 2012-05-09 00:35:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38639, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36639 - magicLinkCallback does not support protocol-relative URLs
magicLinkCallback does not support protocol-relative URLs
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2012-05-08 13:50 UTC by Gadget850
Modified: 2012-05-09 00:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gadget850 2012-05-08 13:50:19 UTC
The PMID magic link does not support a protocol-relative URL. For example:

PMID 12122621

Will always direct to http:// even when you are logged onto the secure server.

The RFC magic link does supports a protocol-relative URL.
Comment 1 Krinkle 2012-05-08 21:40:37 UTC
PMID and RFC magic links (and others) are detected from the Parser::magicLinkCallback method.

The urls themselves are defined in interface messages:
* https://www.mediawiki.org/wiki/MediaWiki:pubmedurl
* https://www.mediawiki.org/wiki/MediaWiki:rfcurl
* (ISBN is indirect, it goes to Special:Booksources first)

Both the PMID and RFC messages are are set to protocol-relative urls

And testing it in a sandbox:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Shows that they are working fine.
Comment 2 Krinkle 2012-05-08 21:41:27 UTC
Accessing it through the secure HTTPS server:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Also works. Please re-open if this is still a problem.
Comment 3 Gadget850 2012-05-08 23:28:26 UTC
Krinkle: Your sandbox works for me.

But not on the English Wikipedia:

https://en.wikipedia.org/wiki/User:Gadget850/Bug_36639
Comment 4 Hazard-SJ 2012-05-08 23:42:45 UTC
I'd assume the change was not deployed there as yet.
Comment 5 Krinkle 2012-05-08 23:51:23 UTC
No, it was changed in november 2011:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=08a311234de6a76cc6d737fb1704245fa93951e8

en.wikipedia community locally changed their PMID url:

https://en.wikipedia.org/w/index.php?title=MediaWiki:Pubmedurl&action=history

The RFC one does work on en.wikipedia.org
Comment 6 Krinkle 2012-05-08 23:56:35 UTC
I've requested the local change to be deleted on en.wikipedia.org.

Resolving this bug as INVALID since this is not a bug in the mediawiki software.
Comment 7 Hazard-SJ 2012-05-09 00:31:43 UTC
Okay.
Comment 8 Gadget850 2012-05-09 00:35:31 UTC
Thanks. Didn't know that was there.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links