Last modified: 2014-08-30 02:35:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38552, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36552 - Diff incorrectly reports incorrect line numbers
Diff incorrectly reports incorrect line numbers
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 37139
  Show dependency tree / graph
 
Reported: 2012-05-05 18:15 UTC by Jim Holmes
Modified: 2014-08-30 02:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Line number is off when showing changes (152.43 KB, image/png)
2012-05-05 18:15 UTC, Jim Holmes 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jim Holmes 2012-05-05 18:15:32 UTC 
Created attachment 10520 [details]
Line number is off when showing changes

When using "Show Changes" the line number is off by one. 

Safari 5.1.5 on OSx Lion.

http://en.wikisource.org/w/index.php?title=Page:The_book_of_try_and_learn.djvu/1&action=submit

Repro: Edit page, change text on first line. Click "Show Changes".

Expected: Line Number at top should show Line 1
Actual: Line number shows Line 2
Comment 1 Mark A. Hershberger 2012-05-07 18:10:46 UTC 
Also, the </noinclude> is exposed.
Comment 2 Krinkle 2012-05-27 13:35:38 UTC 
Moving to Proofread Extension. This is not a bug in MediaWiki core, which does everything just fine (try it on a simple sandbox page).

The proofread extension is using some hacky javascript implementation that, when the page loads, removes part of the javascript and puts it back in when submitting the form. That first line isn't miscalculated, it is really there.
Comment 3 George Orwell III 2014-08-30 02:35:02 UTC 
I can't reproduce this effect no matter if my Prefs are set to show or hide the Proofread Page: header & footer fields first.

I think this resolved (inadvertently) with the refactoring of the extension back in January ( Bugzilla 46616 ).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links