Last modified: 2012-09-19 21:00:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38473, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36473 - "Diff All Side-by-Side" always opens diffs based on Base
"Diff All Side-by-Side" always opens diffs based on Base
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://code.google.com/p/gerrit/issue...
: upstream
Depends on: 37406
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-03 09:51 UTC by Siebrand Mazeland
Modified: 2012-09-19 21:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2012-05-03 09:51:19 UTC 
"Diff All Side-by-Side" always opens diffs based on Base, even if in "Old Version History:" a patch set other than base is selected.

Steps to reproduce:
1. Go to https://gerrit.wikimedia.org/r/#change,5783
2. In "Old Version History:", select "Patch Set 1"

Observed:
* Now only "manifests/misc-servers.pp" and "Commit Message" are shown as changes in Patch Set 2.

3. Click "Diff All Side-by-Side"

Observed:
* Three new tabs open: "files/logrotate/translationnotifications", "manifests/misc-servers.pp" and "Commit Message".
* Diffs are displayed based on Base, not on Patch Set 1.

Expected:
* Two new tabs open: "manifests/misc-servers.pp" and "Commit Message".
* Diffs are displayed based on Patch Set 1.
Comment 1 Siebrand Mazeland 2012-05-03 22:48:05 UTC 
The documentation for the upstream keyword is "Marker for bugs waiting on fix from upstream software vendor. Bugs marked this way *should* include a link to the upstream bug report!". What's the upstream bug URL?
Comment 2 Chad H. 2012-06-08 12:41:41 UTC 
This is fixed in 2.4, adding dependency.
Comment 3 Chad H. 2012-07-06 15:03:53 UTC 
Working in 2.4.2, marking FIXED.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links