Last modified: 2012-08-04 21:10:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38466, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36466 - Article Feedback Page - 'Featured' label is covered by tools panel
Article Feedback Page - 'Featured' label is covered by tools panel
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Yoni Shostak
:
Depends on:
Blocks: 39043
  Show dependency treegraph
 
Reported: 2012-05-03 06:42 UTC by Fabrice Florin
Modified: 2012-08-04 21:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Feedback page mockup with 'Featured' label overlapping text comment (191.13 KB, image/png)
2012-05-03 06:42 UTC, Fabrice Florin
Details
NEW: New-Feedback-Page-Filter-Line-Wrap.png (227.02 KB, image/png)
2012-05-09 06:05 UTC, Fabrice Florin
Details
Feedback-Form-Display-Issues-Dropdown-Featured-Label.png (287.72 KB, image/png)
2012-05-10 17:27 UTC, Fabrice Florin
Details

Description Fabrice Florin 2012-05-03 06:42:30 UTC
Created attachment 10500 [details]
Feedback page mockup with 'Featured' label overlapping text comment

The 'Featured' label is covered by the tools panel in the Article Feedback Page, as shown in attachment. This occurs more on small screens, and/or when resizing the browser window.

Ideally, the 'Featured' label would be right-aligned, so that it would be flush with the left edge of the tools panel.

However, if the screen is resized below a certain width, perhaps we should no longer show that label at all, to avoid a possible overlap with the comments.

Is there any other solution you would recommend for solving this issue?
Comment 1 Yoni Shostak 2012-05-08 18:05:14 UTC
according to the new design, the featured label is moved to the left.
closing, deprecated.
Comment 2 Fabrice Florin 2012-05-09 06:05:06 UTC
Actually, the 'Featured' and 'Resolved' labels still get in the way when the window is resized, causing a line-wrap overlapping the gray tools panel, as shown in this new attachment (New-Feedback-Page-Filter-Line-Wrap.png). 

As part of the new design, these 'Featured' and 'Resolved' labels should fail more gracefully, rather than collide with the tools panel. Would it be possible to make these labels disappear if the screen is resized to the point that they would start overlapping the tools panel?

Also, would it be possible to make the 'Featured' and 'Resolved' labels be right-aligned next to the tools panels? (instead of the current fixed position relative to the left column)

I have re-opened this ticket so we can resolve this issue in the context of the new page design.
Comment 3 Fabrice Florin 2012-05-09 06:05:55 UTC
Created attachment 10562 [details]
NEW: New-Feedback-Page-Filter-Line-Wrap.png
Comment 4 Pau Giner 2012-05-09 18:54:14 UTC
I tried a solution for this that consists in the following:

Make the following changes to "articleFeedbackv5-comment-tags":
  float: right;
  padding-right: 15px;

and move "articleFeedbackv5-comment-tags" tags in the HTML after "articleFeedbackv5-feedback-tools".


Set a minimal with to the whole post by adding to "articleFeedbackv5-feedback"
  min-width:850px;


With this, the featured label gets replaced according to the available room and the action bar does not overlap with the post content. I have uploaded a video to show the result (only the post at the center of the screen has the modifications applied):
http://youtu.be/sKG3DMqndtQ
Comment 5 Pau Giner 2012-05-10 07:43:33 UTC
I created an updated version of the previous proposed changes where:
* articlefeedbackv5-content-wrap elements have been set their width from 60% to 70%
* and the minimal width for posts has been set to 950px (instead of 850px). This change avoids the "flag as abuse" link to move to a new line but makes the design stop adapting at a bigger screen size.

I recreated the effect in a new video: http://youtu.be/23Rc1ZjTsME
Comment 6 Reha Sterbin 2012-05-10 15:11:16 UTC
Changed to match Pau's suggestion and submitted to gerrit with the rest of the redesign:

https://gerrit.wikimedia.org/r/7151
Comment 7 Fabrice Florin 2012-05-10 17:27:00 UTC
Thank you, Pau and Reha!

Seems like a good solution overall.

I am a bit confused by why the 'Featured' label behaves differently for different posts, as shown in the attached Firefox screenshot. (Feedback-Form-Display-Issues-Dropdown-Featured-Label.png)

Is this because one feedback post is shorter than the other one?
Comment 8 Fabrice Florin 2012-05-10 17:27:34 UTC
Created attachment 10579 [details]
Feedback-Form-Display-Issues-Dropdown-Featured-Label.png

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links