Last modified: 2014-02-12 23:52:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38182, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36182 - Switching between desktop and mobile view should redirect to canonical URLs
Switching between desktop and mobile view should redirect to canonical URLs
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Arthur Richards
:
Depends on:
Blocks: 30772
  Show dependency treegraph
 
Reported: 2012-04-23 16:29 UTC by Max Semenik
Modified: 2014-02-12 23:52 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-04-23 16:29:59 UTC
Currently, it redirects to /w/index.php?title=foo , which results in stale cache:

http://en.m.wikipedia.org/w/index.php?title=Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962
Last-Modified: Mon, 23 Apr 2012 05:59:47 GMT

vs.

http://en.m.wikipedia.org/wiki/Wage_reform_in_the_Soviet_Union,_1956–1962
Last-Modified: Mon, 23 Apr 2012 16:14:15 GMT
Comment 1 Jon 2012-06-27 00:17:53 UTC
Any update on this bug? Is this an easy change?
Comment 2 Max Semenik 2012-06-27 17:23:35 UTC
Submitted for review in https://gerrit.wikimedia.org/r/13185
Comment 3 Max Semenik 2012-07-04 20:12:51 UTC
Still not resolved, I see instances when this fix works on live site and some when it doesn't.
Comment 4 Arthur Richards 2012-10-03 21:19:20 UTC
Max, can you give examples of where this is not working? One that I found quickly was on pages like:
http://en.wikipedia.org/wiki/Portal:Featured_content
http://en.wikipedia.org/wiki/Wikipedia:About

Is this a namespace related issue?
Comment 5 Max Semenik 2012-10-03 21:30:45 UTC
(In reply to comment #4)
> Is this a namespace related issue?

Maybe, I'll need to investigate this.
Comment 6 Arthur Richards 2012-12-04 19:53:28 UTC
I think I've resolved this for desktop -> mobile requests that happen on sites that have a mobile URL template defined (eg the WMF cluster): https://gerrit.wikimedia.org/r/#/c/36809/1

This should make all 'mobile view' links canonical, all the time. This should work fine on the WMF cluster which passes all .m traffic through the mobile varnish servers, which will always result in a mobile view (even without ?mobileaction=toggle_mobile_view).

This approach will not work in the reverse (mobile -> desktop view) because we need the mobileaction query param for non-js browsers to set the stopMobileRedirect cookie.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links