Last modified: 2013-12-03 02:33:00 UTC
There are some texts which make using the extension in non Wikimedia context problematic: "Thanks for using our new upload tool! Help with translations" - it's not necessarily new nor do the users need to concern themselves with translations. Suggesting that this is moved to local customization. "Select a media file to donate" - user's are not necessarily donating anything. Suggesting to have neutral wording "Select a file to upload" by default, having the other wording again as local customization or configuration option.
One more: "You can now use this file on sites like Wikipedia, or link to it on the web."
Marking as easy, this should only take a few lines of code to fix, most of it just editing i18n strings. Will need to move one thing into the config file, too.
Also, from <https://translatewiki.net/wiki/Thread:Support/Upload_wizard_upload_button> (in addition to bug 43984): "the UploadWizard supports one or several files. Since this cannot be known in advance, the message must cover both case". Technically if one selects multiple media it's correct to say one has selected one [at least], while it's not true of the contrary; non-verbose translatable options needed.
https://gerrit.wikimedia.org/r/54688 fixes the last comment.
Marking as a candidate for GCI.
@Niklas, what would you suggest instead for that last one? Would something like this make sense? Or did you have something else in mind? :/ "You can now use this file on wikis, or link to it on the web." Re your first issue, I think the easiest way to do this is to just add two new config options: * headerMessage, which can be set to a string that replaces "Thanks for using our new upload tool!" or alternatively set to "default" which uses the standard i18n translations for "Thanks for using our new upload tool!" (so as to be backwards-compatible and all). * showTranslateLink, which determines whether or not the "Help with translations" link is displayed. Finally, it looks like the "Select a media file to donate" deal has already been resolved (changed to "share"/"upload"). Am I missing anything here (or is there anything that needs further discussion)? Otherwise I'll get to working on a patch for this :)
A Google Code-in student (Theopolisme, actually) is allegedly working on this task: http://www.google-melange.com/gci/task/view/google/gci2013/5897248466534400
(In reply to comment #6) > @Niklas, what would you suggest instead for that last one? Would something > like > this make sense? Or did you have something else in mind? :/ > > "You can now use this file on wikis, or link to it on the web." OK. > > Re your first issue, I think the easiest way to do this is to just add two > new > config options: > > * headerMessage, which can be set to a string that replaces "Thanks for using > our new upload tool!" or alternatively set to "default" which uses the > standard > i18n translations for "Thanks for using our new upload tool!" (so as to be > backwards-compatible and all). > > * showTranslateLink, which determines whether or not the "Help with > translations" link is displayed. Those are viable solutions, though they make sense only if you also submit a patch for such a configuration against operations/mediawiki-config repo. Additional configurations are hardly the easiest way; this part could just be removed, it's been a while since UploadWizard has been introduced on this and other wikis.
Change 98148 had a related patch set uploaded by Theopolisme: Update and remove unnecessary messages https://gerrit.wikimedia.org/r/98148
Change 98148 merged by jenkins-bot: Update and remove unnecessary messages https://gerrit.wikimedia.org/r/98148
We're gonna call this closed now that we've axed the message entirely and updated other problematic ones. Thanks, Theopolisme!
